[issue18549] Dead code in socket_ntohl()

Roundup Robot added the comment: New changeset b7ea3f94f6ca by Christian Heimes in branch '3.3': Issue #18549: Eliminate dead code in socket_ntohl(). http://hg.python.org/cpython/rev/b7ea3f94f6ca New changeset 2a59428dbff5 by Christian Heimes in branch 'default': Issue #18549: Eliminate dead cod

[issue18549] Dead code in socket_ntohl()

Christian Heimes added the comment: Thanks for the review! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue18549] Dead code in socket_ntohl()

Serhiy Storchaka added the comment: Agree, it can be removed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18549] Dead code in socket_ntohl()

New submission from Christian Heimes: http://hg.python.org/cpython/file/96d817f41c4c/Modules/socketmodule.c#l4642 The code has two checks if (x == (unsigned long) -1 && PyErr_Occurred()). Coverity claims that the second time is dead code and I agree. It looks like an artifact from the time the