[issue18521] [cppcheck] Full report

Georg Brandl added the comment: Closing this one as Fixed, then. Thanks everybody. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue18521] [cppcheck] Full report

Georg Brandl added the comment: > Shouldn't converttuple() in getargs.c set "levels[1] = 0;" after second > "levels[0] = i+1;"? I think it is fine, since convertitem() or converttuple() called from convertitem() will set their levels[0] (which is levels[1] in the original context) to zero on

[issue18521] [cppcheck] Full report

Serhiy Storchaka added the comment: Agree that all other looks false positive or unimportant. -- ___ Python tracker ___ ___ Python-bug

[issue18521] [cppcheck] Full report

Serhiy Storchaka added the comment: Shouldn't converttuple() in getargs.c set "levels[1] = 0;" after second "levels[0] = i+1;"? -- ___ Python tracker ___ ___

[issue18521] [cppcheck] Full report

Georg Brandl added the comment: I fixed some items from Ezio's list that I think were legitimate; the rest is mostly invalid. -- nosy: +georg.brandl ___ Python tracker ___ _

[issue18521] [cppcheck] Full report

Roundup Robot added the comment: New changeset 63bc2fe28a6e by Georg Brandl in branch 'default': Re #18521: move array bounds check before array access. http://hg.python.org/cpython/rev/63bc2fe28a6e -- ___ Python tracker

[issue18521] [cppcheck] Full report

Roundup Robot added the comment: New changeset 7396d10405db by Georg Brandl in branch 'default': Re #18521: remove assignments of variables that are immediately reassigned. http://hg.python.org/cpython/rev/7396d10405db -- ___ Python tracker

[issue18521] [cppcheck] Full report

Roundup Robot added the comment: New changeset eaeaed43ff1c by Georg Brandl in branch 'default': Re #18521: fix not-quite-C syntax that works only because the PyXXX_Check are macros defined with () around them. http://hg.python.org/cpython/rev/eaeaed43ff1c -- nosy: +python-dev

[issue18521] [cppcheck] Full report

Ezio Melotti added the comment: I grouped the errors by message and checked of there were any actual errors. Most of the reports seemed wrong or false positive, but a few looked fixable. I haven't checked the "Unusued variable" ones, because they are harmless (even thought we could clean the

[issue18521] [cppcheck] Full report

Julien Nabet added the comment: Thank you for your feedback, you can close this tracker. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue18521] [cppcheck] Full report

Martin v. Löwis added the comment: Julien: I propose to resolve this issue in the same way as we have done previously with analysis tools (with some unfortunate exceptions). Somebody motivated enough (hopefully you) agrees to initially study the tool output, and ideally also then agrees to run

[issue18521] [cppcheck] Full report

Ronald Oussoren added the comment: It doesn't really live up to its description. >From the start of the 'filtered' list: * Messages about PyThread_acquire_lock appear to be false positives, that name is a function that's called by the macros expanded on those lines. * Syntax error in _ctyp

[issue18521] [cppcheck] Full report

Julien Nabet added the comment: quotation from http://en.wikipedia.org/wiki/Cppcheck : " Cppcheck is a static code analysis tool for the C and C++ programming languages " or from http://cppcheck.sourceforge.net/ " Cppcheck is a static analysis tool for C/C++ code. Unlike C/C++ compilers and many

[issue18521] [cppcheck] Full report

Ronald Oussoren added the comment: What is cppcheck? The report contains some very dodgy false positives, like: [Modules/_cursesmodule.c:1095]: (style) Variable 'rtn' is assigned a value that is never used. [Modules/_cursesmodule.c:1097]: (style) Unused variable: break 1) The "rtn" is used fu

[issue18521] [cppcheck] Full report

Julien Nabet added the comment: Here's a new version of the file after some filtering (for the record, I used this command line: grep -v 'The scope' cppcheck_reports.txt |grep -v 'Modules/_ctypes/libffi' |grep -v Modules/_sha3/keccak| grep -v Modules/expat | grep -v Modules/_decimal/libmpdec |g

[issue18521] [cppcheck] Full report

Christian Heimes added the comment: The report contains too much noise to be useful. I suggest that you remove some of the noise. * get rid of "The scope of the variable 'foo' can be reduced.". It's nit-picking. * ignore 3rd party code: Modules/_ctypes/libffi*, Modules/_sha3/keccak, Modules/

[issue18521] [cppcheck] Full report

New submission from Julien Nabet: Hello, I retrieved Cpython sources today and runned cppcheck ("git updated" today) on the whole sources with enable=all I attached the full report. There are certainly false positive but some reports may help, eg: [Python/getargs.c:379]: (style) Array index 'i'