[issue18439] Patchcheck for ACKS, NEWS does not work on Windows.

2013-07-21 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue18439] Patchcheck for ACKS, NEWS does not work on Windows.

2013-07-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 26686d227e41 by Terry Jan Reedy in branch '3.3': Issue #18439: Make patchcheck work on Windows for ACKS, NEWS. http://hg.python.org/cpython/rev/26686d227e41 New changeset 13950a33f889 by Terry Jan Reedy in branch '2.7': Issue #18439: Make patchcheck

[issue18439] Patchcheck for ACKS, NEWS does not work on Windows.

2013-07-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Sorry, I forgot to paste the patch diff into Notepad++ rather than Idle in order to save it without \r. (That would be a useful option for Idle too.) Good to know that I can forget about Classic Mac. I deleted the debug print. -- _

[issue18439] Patchcheck for ACKS, NEWS does not work on Windows.

2013-07-21 Thread Ned Deily
Ned Deily added the comment: Re the patch: it looks like there's a debugging print left in it. (Also, FYI, the patch did not apply cleanly using normal Unix patch; I had to strip the \r characters with (tr -d '\r' ___ ___

[issue18439] Patchcheck for ACKS, NEWS does not work on Windows.

2013-07-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ronald or Ned, is the attached patch OK for Macs? -- assignee: -> terry.reedy keywords: +patch nosy: +ned.deily, ronaldoussoren stage: needs patch -> commit review Added file: http://bugs.python.org/file30999/patchcheck.diff ___

[issue18439] Patchcheck for ACKS, NEWS does not work on Windows.

2013-07-13 Thread R. David Murray
R. David Murray added the comment: Using os.path.join to create the filenames should also work, I would think. -- nosy: +r.david.murray ___ Python tracker ___ ___

[issue18439] Patchcheck for ACKS, NEWS does not work on Windows.

2013-07-12 Thread Terry J. Reedy
New submission from Terry J. Reedy: My current list of changed_files() (command from the code) % hg status --added --modified --no-status Lib\idlelib\RstripExtension.py Misc\ACKS Misc\NEWS Lib\idlelib\idle_test\mock_idle.py Lib\idlelib\idle_test\test_rstrip.py but F:\Python\dev\py33>pcbuild\pyth