[issue18407] Fix compiler warnings in pythoncore for Win64

STINNER Victor added the comment: Almost all compiler warnings on 64-bit Windows have been fixed: bpo-9566 tracked most of them. I extract the CryptGenRandom() fix from issue18407-2.diff. I rewrote the ast.c fix differently (use larger type, don't downcast). The patch may still contains rel

[issue18407] Fix compiler warnings in pythoncore for Win64

STINNER Victor added the comment: New changeset 4d73ae776140a583fdfe8f016d88cc767791e481 by Victor Stinner in branch 'master': bpo-18407: ast.c uses Py_ssize_t for asdl_seq_LEN() iterator (GH-10655) https://github.com/python/cpython/commit/4d73ae776140a583fdfe8f016d88cc767791e481 --

[issue18407] Fix compiler warnings in pythoncore for Win64

STINNER Victor added the comment: New changeset c48ff73dd60bec5dcbe64bedeff91e6db26d98bc by Victor Stinner in branch 'master': bpo-18407: win32_urandom() uses PY_DWORD_MAX (GH-10656) https://github.com/python/cpython/commit/c48ff73dd60bec5dcbe64bedeff91e6db26d98bc -- __

[issue18407] Fix compiler warnings in pythoncore for Win64

Change by STINNER Victor : -- pull_requests: +9909 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue18407] Fix compiler warnings in pythoncore for Win64

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue18407] Fix compiler warnings in pythoncore for Win64

Change by STINNER Victor : -- pull_requests: +9908 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18407] Fix compiler warnings in pythoncore for Win64

Steve Dower added the comment: Does the patch still apply cleanly? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue18407] Fix compiler warnings in pythoncore for Win64

Mark Lawrence added the comment: Would someone like to review the patch please, being aware that there are other open issues relating to compiler warnings on Windows. -- nosy: +steve.dower, zach.ware ___ Python tracker

[issue18407] Fix compiler warnings in pythoncore for Win64

Mark Lawrence added the comment: Can we have the stage set to patch review please. -- nosy: +BreamoreBoy -brian.curtin versions: +Python 3.5 ___ Python tracker ___ __

[issue18407] Fix compiler warnings in pythoncore for Win64

Jeremy Kloth added the comment: Added new patch that removes the duplicate changes from issue #15792 and comments the lone explicit cast. These changes fix 116 of the 216 warnings (54%!) for Win64. Together with issue #15792 brings the remaining count to 72. I am unsure if splitting the chan

[issue18407] Fix compiler warnings in pythoncore for Win64

Jeremy Kloth added the comment: Ugh, sorry for the bad quoting (silly GMail). -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue18407] Fix compiler warnings in pythoncore for Win64

Jeremy Kloth added the comment: The change in grammar.c:addlabel() is correct. The return value is an index into the ll->ll_label array, thus an int. The code could be rewritten to avoid the pointer addition by saving the value of ll->ll_nlabels before it is incremented and return that instead,

[issue18407] Fix compiler warnings in pythoncore for Win64

Jeremy Kloth added the comment: Yeah, sorry. This made it in by mistake. It was in the tree just to eliminate warning noise. On Mon, Jul 8, 2013 at 1:20 PM, STINNER Victor wrote: > > STINNER Victor added the comment: > > - /USECL:MS_OPTERON /GS- > %(AdditionalOptions) > + false > >

[issue18407] Fix compiler warnings in pythoncore for Win64

STINNER Victor added the comment: This issue duplicates the isuse #9566, but your patch is interesting. I created other more specific issues like #18295 and #18294. -return lb - ll->ll_label; +return Py_SAFE_DOWNCAST(lb - ll->ll_label, Py_intptr_t, int); I don't think that such change

[issue18407] Fix compiler warnings in pythoncore for Win64

STINNER Victor added the comment: - /USECL:MS_OPTERON /GS- %(AdditionalOptions) + false Please don't change too much things in the same patch. The issue #15792 is a better place for such change. -- ___ Python tracker

[issue18407] Fix compiler warnings in pythoncore for Win64

Changes by Jeremy Kloth : -- components: +Build, Windows type: -> compile error versions: +Python 3.4 ___ Python tracker ___ ___ Pyth

[issue18407] Fix compiler warnings in pythoncore for Win64

New submission from Jeremy Kloth: The attached patch fixes compiler warnings for the pythoncore project when building on 64-bit Windows. Fixes for built-in modules are not included, however. -- files: issue18407.diff keywords: patch messages: 192686 nosy: brian.curtin, christian.heimes