[issue18321] Multivolume support in tarfile module

Lars Gustäbel added the comment: Okay, let me tell you why I reject your contribution at this point. The patch you submitted may be well-suited for your purposes but it does not meet the requirements of a standard library implementation because it is not generic and comprehensive enough. It c

[issue18321] Multivolume support in tarfile module

Eduardo Robles Elvira added the comment: >> [...] but remember, we split a volume only in the middle of a big file, not >> in any other case (AFAIK). Hopefully you don't get huge pax headers or >> anything strange. [...] > Hopefully? Sorry, but have you tested this? I did. I let GNU tar create

[issue18321] Multivolume support in tarfile module

Lars Gustäbel added the comment: > [...] but remember, we split a volume only in the middle of a big file, not > in any other case (AFAIK). Hopefully you don't get huge pax headers or > anything strange. [...] Hopefully? Sorry, but have you tested this? I did. I let GNU tar create a two volu

[issue18321] Multivolume support in tarfile module

Eduardo Robles Elvira added the comment: > The example I gave is based on the idea that there is a TarVolumeSet class in > the tarfile module that implements all the required file-object methods (e.g. > read(), write(), seek(), etc.) and acts as if the sequence of volumes is > actually one bi

[issue18321] Multivolume support in tarfile module

Lars Gustäbel added the comment: > It's also consistent with how the tar command works afaik, just listing the > contents of the current volume. No, GNU tar operates on the entirety of the archive and asks for the filename of the subsequent volume every time it hits eof in the current volume.

[issue18321] Multivolume support in tarfile module

Eduardo Robles Elvira added the comment: I guess I got it wrong, it's not part of the POSIX standard, just part of the GNU tar documentation. About the getmembers and getnames not reflecting the entirety of the archive, it's an optimization I needed and I think ccan be quite handy. It's also c

[issue18321] Multivolume support in tarfile module

Lars Gustäbel added the comment: I had the following idea: What about a separate class, let's call it TarVolumeSet for now, that maps a set of (virtual) volumes onto one big file-like object. This TarVolumeSet will be passed to a TarFile constructor as the fileobj argument. It is subclassable

[issue18321] Multivolume support in tarfile module

Lars Gustäbel added the comment: At first, I'd like to take back my comment on this patch being too complex for too little benefit. That is no real argument. Okay, I gave it a shot and I have a few more remarks: The patch does not support iterating over a multi-volume tar archive, e.g. for Ta

[issue18321] Multivolume support in tarfile module

Eduardo Robles Elvira added the comment: > I cannot yet go into the details, because I have not tested the patch. > The comments, docstrings and quoting are not very consistent with the rest of > the module. There are a few spelling mistakes. I can try to take care of this, though it'd be bes

[issue18321] Multivolume support in tarfile module

Lars Gustäbel added the comment: I cannot yet go into the details, because I have not tested the patch. The comments, docstrings and quoting are not very consistent with the rest of the module. There are a few spelling mistakes. The open_volume() method is more or less a copy of the open() met

[issue18321] Multivolume support in tarfile module

Changes by Berker Peksag : -- versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18321] Multivolume support in tarfile module

Martin v. Löwis added the comment: Lars, would you like to take a look? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue18321] Multivolume support in tarfile module

Eduardo Robles Elvira added the comment: Do we have any news on this patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue18321] Multivolume support in tarfile module

Christian Heimes added the comment: You have an asterisk next to your user name. So yes, your form was received and processed. -- nosy: +christian.heimes ___ Python tracker ___

[issue18321] Multivolume support in tarfile module

Eduardo Robles Elvira added the comment: could you please check if my contributor form is already processed? -- ___ Python tracker ___ ___

[issue18321] Multivolume support in tarfile module

Eduardo Robles Elvira added the comment: Sure, I will fill it out. But is it required? -- ___ Python tracker ___ ___ Python-bugs-list

[issue18321] Multivolume support in tarfile module

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue18321] Multivolume support in tarfile module

Martin v. Löwis added the comment: Eduardo, can you please fill out the contributor form? -- nosy: +loewis ___ Python tracker ___ ___

[issue18321] Multivolume support in tarfile module

Changes by Serhiy Storchaka : -- nosy: +lars.gustaebel stage: -> patch review type: -> enhancement ___ Python tracker ___ ___ Python

[issue18321] Multivolume support in tarfile module

New submission from Eduardo Robles Elvira: The patch attached provides implementation for multivolume support for tarfile module. It contains both the changes in the module and a battery of unit tests. It contains support for multivolume for both GNU and PAX formats. The main idea behind this