[issue18202] Minor fixes for test_coding

Serhiy Storchaka added the comment: Not all other changes are cleanups and enhancements. Some of them also fix minor bugs. Thank you for review Victor. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed

[issue18202] Minor fixes for test_coding

Roundup Robot added the comment: New changeset 410ea970866e by Serhiy Storchaka in branch '3.3': Issue #18202: Fix minor bugs and cleanup test_coding.py. http://hg.python.org/cpython/rev/410ea970866e New changeset 959f4ce4d590 by Serhiy Storchaka in branch 'default': Issue #18202: Fix minor bugs

[issue18202] Minor fixes for test_coding

STINNER Victor added the comment: The patch looks good to me. It may be better to split it in two commits: fix test_exec_valid_coding() in Python 3.3, cleanup test only in python 3.4. As you want. -- ___ Python tracker

[issue18202] Minor fixes for test_coding

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18202] Minor fixes for test_coding

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file30570/test_coding.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue18202] Minor fixes for test_coding

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file30569/test_coding.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue18202] Minor fixes for test_coding

New submission from Serhiy Storchaka: Here is a patch which contains followed changes: * Use bytes in test_exec_valid_coding(). Encoding instruction is ignored in strings. * Use non-ascii data in test_exec_valid_coding() to check that encoding is working. * Use explicit file encoding in test_f