[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: I think it is unlikely that the timeouts on Azure CI are related to this change. -- ___ Python tracker ___ _

[issue18049] Re-enable threading test on macOS

STINNER Victor added the comment: > Ronald, is it feasible that the changes made in > https://github.com/python/cpython/pull/14748/files to THREAD_STACK_SIZE in > Python/thread_pthread.h could be causing intermittent failures for the Azure > macOS PR tests? See also bpo-37245 ("Azure Pipeli

[issue18049] Re-enable threading test on macOS

Karthikeyan Singaravelan added the comment: @aeros167 The build log failures due to timeout in the linked Azure pipeline failure seem to be similar to report at issue37245 -- nosy: +xtreak ___ Python tracker __

[issue18049] Re-enable threading test on macOS

Kyle Stanley added the comment: Ronald, is it feasible that the changes made in https://github.com/python/cpython/pull/14748/files to THREAD_STACK_SIZE in Python/thread_pthread.h could be causing intermittent failures for the Azure macOS PR tests? In a recent PR (https://github.com/python/c

[issue18049] Re-enable threading test on macOS

miss-islington added the comment: New changeset f92bb6ed336c49cabf30717c3b741b1b4284f491 by Miss Islington (bot) in branch '3.8': bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion limit test (GH-15081) https://github.com/python/cpython/commit/f92bb6ed336c49cabf30717c3b741

[issue18049] Re-enable threading test on macOS

Change by miss-islington : -- pull_requests: +15248 pull_request: https://github.com/python/cpython/pull/15572 ___ Python tracker ___ __

[issue18049] Re-enable threading test on macOS

STINNER Victor added the comment: The test does now crash on FreeBSD: see bpo-37906. -- ___ Python tracker ___ ___ Python-bugs-list

[issue18049] Re-enable threading test on macOS

Change by Ronald Oussoren : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue18049] Re-enable threading test on macOS

Change by miss-islington : -- pull_requests: +14834 pull_request: https://github.com/python/cpython/pull/15089 ___ Python tracker ___ __

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: New changeset 9670ce76b83bde950020f8d89c4d27168aaaf912 by Ronald Oussoren (Michael Felt) in branch 'master': bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion limit test (GH-15081) https://github.com/python/cpython/commit/9670ce76b83bde9

[issue18049] Re-enable threading test on macOS

Change by Michael Felt : -- pull_requests: +14827 pull_request: https://github.com/python/cpython/pull/15081 ___ Python tracker ___

[issue18049] Re-enable threading test on macOS

Michael Felt added the comment: On 02/08/2019 11:57, Michael Felt wrote: > On 02/08/2019 11:48, Ronald Oussoren wrote: >> Ronald Oussoren added the comment: >> >> That code is only called if THREAD_STACK_SIZE is defined. The block I >> mention defines it for macOS and FreeBSD, but not for othe

[issue18049] Re-enable threading test on macOS

Michael Felt added the comment: On 02/08/2019 11:48, Ronald Oussoren wrote: > Ronald Oussoren added the comment: > > That code is only called if THREAD_STACK_SIZE is defined. The block I mention > defines it for macOS and FreeBSD, but not for other platforms. I therefore > expect that this c

[issue18049] Re-enable threading test on macOS

Michael Felt added the comment: Going to take a stab in the dark - the the issue lies here: "./Python/errors.c" #ifndef Py_NORMALIZE_RECURSION_LIMIT #define Py_NORMALIZE_RECURSION_LIMIT 32 #endif As there is not enough memory for this to run in the default memory model. However, 32 does not

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: That code is only called if THREAD_STACK_SIZE is defined. The block I mention defines it for macOS and FreeBSD, but not for other platforms. I therefore expect that this code is not used on AIX (which would be easy enough to verify by adding an #error to th

[issue18049] Re-enable threading test on macOS

Michael Felt added the comment: *** Looking in ./Python/thread_pthread.h" +252 #if defined(THREAD_STACK_SIZE) +253 PyThreadState *tstate = _PyThreadState_GET(); +254 size_t stacksize = tstate ? tstate->interp->pythread_stacksize : 0; +255 tss = (stacksize != 0) ? stack

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: @Michael: The relevant code is in Python/thread_pthread.h: https://github.com/python/cpython/blob/bf8162c8c45338470bbe487c8769bba20bde66c2/Python/thread_pthread.h#L34 There are already blocks for macOS and FreeBSD, adding a block for AIX should be easy eno

[issue18049] Re-enable threading test on macOS

Michael Felt added the comment: @Ronald - thanks. Gives me something to work from. Would not have found this so easily! But - where to put it... :) -- nosy: +Michael.Felt ___ Python tracker ___

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: PR 15075 should fix this issue. As mentioned in that PR I do have a question w.r.t. the exact shape of that patch: I currently reintroduce a "skipUnless" decorator that only runs this test on macOS, I could also introduce one that just disables the test on

[issue18049] Re-enable threading test on macOS

Change by Ronald Oussoren : -- pull_requests: +14822 pull_request: https://github.com/python/cpython/pull/15075 ___ Python tracker ___ _

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: The patch to fix this should be: diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py index 1466d25e94..658bc1c7a0 100644 --- a/Lib/test/test_threading.py +++ b/Lib/test/test_threading.py @@ -1057,6 +1057,7 @@ class ThreadingExceptionTests(Bas

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: That is related, my patch removes a guard that should enable this test only on macOS. This fragment is the issue: - @unittest.skipUnless(sys.platform == 'darwin' and test.support.python_is_optimized(), -'test macosx problem')

[issue18049] Re-enable threading test on macOS

miss-islington added the comment: New changeset 8399641c34d8136c3151fda6461cc4727a20b28e by Miss Islington (bot) in branch '3.8': bpo-18049: Sync thread stack size to main thread size on macOS (GH-14748) https://github.com/python/cpython/commit/8399641c34d8136c3151fda6461cc4727a20b28e -

[issue18049] Re-enable threading test on macOS

STINNER Victor added the comment: I'm not sure if it's related, but test_threading.test_recursion_limit() started to crash on two AIX buildbot workers after commit 1a057bab0f18d6ad843ce321d1d77a4819497ae4: https://bugs.python.org/issue36273#msg348845 -- nosy: +vstinner _

[issue18049] Re-enable threading test on macOS

Change by miss-islington : -- pull_requests: +14814 pull_request: https://github.com/python/cpython/pull/15065 ___ Python tracker ___ __

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: New changeset 1a057bab0f18d6ad843ce321d1d77a4819497ae4 by Ronald Oussoren in branch 'master': bpo-18049: Sync thread stack size to main thread size on macOS (GH-14748) https://github.com/python/cpython/commit/1a057bab0f18d6ad843ce321d1d77a4819497ae4 --

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: W.r.t. PyOS_CheckStack: I had that idea last year as well, and someone contributed a pull request, see issue33955. -- ___ Python tracker __

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: I've done some more testing, and the thread stack size could be smaller than 16MB, but definitely not as small as the value that's currently in thread_pthread.h. I prefer to have a slightly too large value here because IIRC the relation between the recursi

[issue18049] Re-enable threading test on macOS

Steve Dower added the comment: I believe this is acceptable to include in 3.8, provided it makes sense for 3.9, so I added the backport tag on the PR. That said, I'm not making any comment on whether it's appropriate at all :) For Windows we found some ways to reduce the stack usage of debug

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: I've converted the patch to a pull request (and closed to other issue because that has a patch that is less complete). I'm not sure if it is acceptable to backport this patch to 3.8 at this time. -- title: Re-enable threading test on OSX -> Re-enabl