[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: The buildbots appear to be happy, no more hanging and no more testLoadWithUNC failure. There is a failure in test_tcl on one bot, but it is not related to this issue. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> clo

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: I'll leave this open until the buildbots prove happy. I did make a couple extra changes to the patch to TclTest.testLoadWithUNC to make a couple of skip conditions actually report a skip instead of just returning, and to remove a superfluous 'import sys'. -

[issue17883] Fix buildbot testing of Tkinter

Roundup Robot added the comment: New changeset 72c3ca3ed22a by Zachary Ware in branch '2.7': Issue #17883: Tweak test_tcl testLoadWithUNC to skip the test in the http://hg.python.org/cpython/rev/72c3ca3ed22a -- ___ Python tracker

[issue17883] Fix buildbot testing of Tkinter

Roundup Robot added the comment: New changeset 358496e67a89 by Zachary Ware in branch '2.7': Issue #17883: Backport test.test_support._is_gui_available() http://hg.python.org/cpython/rev/358496e67a89 -- ___ Python tracker

[issue17883] Fix buildbot testing of Tkinter

Brian Curtin added the comment: The changes look fine to me. -- assignee: terry.reedy -> zach.ware ___ Python tracker ___ ___ Python-b

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: If there are no objections, I'd like to commit both of these in the next day or two (which is nice to be able to say :)). -- nosy: +brian.curtin stage: committed/rejected -> patch review ___ Python tracker

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: Buildbots are still hanging on test_ttk_guionly and failing test_tcl and both patches still apply cleanly. Is there anything I can do to help move this forward again? -- ___ Python tracker

[issue17883] Fix buildbot testing of Tkinter

Changes by Zachary Ware : Removed file: http://bugs.python.org/file30156/issue17883.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17883] Fix buildbot testing of Tkinter

Changes by Zachary Ware : Removed file: http://bugs.python.org/file30196/issue17883-tmp-test.diff ___ Python tracker ___ ___ Python-bugs-list

[issue17883] Fix buildbot testing of Tkinter

Changes by Zachary Ware : Removed file: http://bugs.python.org/file30080/2.7_rt.bat_tcltk_fix.diff ___ Python tracker ___ ___ Python-bugs-list

[issue17883] Fix buildbot testing of Tkinter

Changes by Ezio Melotti : -- assignee: ezio.melotti -> terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: Ping! The buildbots still seem to be failing, are my proposed fixes acceptable? Both patches still apply cleanly. -- ___ Python tracker ___ ___

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: It seems all it took to backport was a copy and paste. Here's the patch. -- Added file: http://bugs.python.org/file30703/issue17883-add_is_gui_available.diff ___ Python tracker ___

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: > Jeremy Kloth added the comment: > > Although the solution for test_ttk_guionly of disabling the gui resource is a > good quick fix, I'm curious as to why there isn't the same issue (test hangs) > when run using 3.3 on the same machine. As it turns out, 3.3(+)'

[issue17883] Fix buildbot testing of Tkinter

Jeremy Kloth added the comment: Although the solution for test_ttk_guionly of disabling the gui resource is a good quick fix, I'm curious as to why there isn't the same issue (test hangs) when run using 3.3 on the same machine. Note that by running as a service without desktop interaction seve

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: Ok, I've managed to cobble together a buildbot setup to test the hang myself and have come up with a couple possible solutions. The first is to change the buildbot service on the slaves to allow desktop interaction. This way, the tests can actually run. If tha

[issue17883] Fix buildbot testing of Tkinter

Jeremy Kloth added the comment: (Note that the buildbot is 64-bit so the paths need to be tcltk64) The test_ttk_guionly passed successfully *from the command-line*. It is currently hung in that test from the buildbot scheduler *as a service*. I do not know of a simple way to test changes via

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: Jeremy, can you give me the output of a test run with issue17883-tmp-test.diff applied? (Or just what a `python -m test -v test_ttk_guionly` gives with ..\tcltk\bin on the PATH) -- ___ Python tracker

[issue17883] Fix buildbot testing of Tkinter

Jeremy Kloth added the comment: It seems that the changes committed by Ezio are causing the AMD64 Windows buildbot to hang in test_ttk_guionly. A note that this buildbot is running as a service so no desktop is available. The same test however is working (skipped successfully) on the 3.3 bran

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: Thanks for your response, Martin. Martin v. Löwis wrote: > Zach: Temporarily committing changes to test specific buildbot issues > is fine I suppose it would also be beneficial to get some output from the other bots which are *not* failing, to have something to

[issue17883] Fix buildbot testing of Tkinter

Martin v. Löwis added the comment: > a) Is Windows Server 2003 is really meant to be spported? Yes > b) Are UNCs expected to behave differently on Server 2003? No. > c) Can UNCs be disabled on a particular machine? I may misunderstand "can": yes, it is possible, but no, it is not desirable.

[issue17883] Fix buildbot testing of Tkinter

Terry J. Reedy added the comment: Amaury and Martin: there is a problem on one machine with test.test_tcl.TclTest.testLoadWithUNC that you two jointly wrote, reviewed, and applied in #6470. This issue (17883) is above getting the tcl/tk/tkinter tests to actually be run on 2.7, which they were

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: I'm not sure where to go with this from here, without knowing more about what's going wrong. Just to make sure there wasn't anything wrong with the Tcl/Tk build or some manner of issue with things not being properly cleaned up or something, I set the 'custom' b

[issue17883] Fix buildbot testing of Tkinter

Ezio Melotti added the comment: Here's the traceback: http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%202.7/builds/435/steps/test/logs/stdio == ERROR: testLoadWithUNC (test.test_tcl.TclTest) -

[issue17883] Fix buildbot testing of Tkinter

Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue17883] Fix buildbot testing of Tkinter

Ezio Melotti added the comment: FTR there's also test.support.assert_python_ok and test.support.assert_python_failure (and a few convenience functions in subprocess too). I suspect that if the import fails, stdout is empty, and stderr will contain the error message. -- _

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: Here's a better patch after learning a bit better how subprocess.Popen works... -- Added file: http://bugs.python.org/file30156/issue17883.diff ___ Python tracker ___

[issue17883] Fix buildbot testing of Tkinter

Changes by Zachary Ware : Removed file: http://bugs.python.org/file30154/issue17883.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17883] Fix buildbot testing of Tkinter

Zachary Ware added the comment: Here's the relevant bit of the output from that buildbot after Terry's change: == FAIL: testLoadWithUNC (test.test_tcl.TclTest)

[issue17883] Fix buildbot testing of Tkinter

Roundup Robot added the comment: New changeset b1abc5800e2b by Terry Jan Reedy in branch '2.7': Issue17883: Update to assertIn to see why test fails on one buildbot. http://hg.python.org/cpython/rev/b1abc5800e2b -- ___ Python tracker

[issue17883] Fix buildbot testing of Tkinter

Terry J. Reedy added the comment: I wonder if there is something special about the environment on that Snakebite machine. At the top, it says PATH=C:\Perl\site\bin;C:\Perl\bin;E:\apps\activestate-python-2.7.2.5-x86\;E:\apps\activestate-python-2.7.2.5-x86\Scripts;... Could the presence of acti

[issue17883] Fix buildbot testing of Tkinter

Ezio Melotti added the comment: Actually one buildbot is failing: http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%202.7/builds/427/steps/test/logs/stdio -- status: closed -> open ___ Python tracker

[issue17883] Fix buildbot testing of Tkinter

Ezio Melotti added the comment: The buildbots run the tests and seem happy. Thanks for the report and the patch! -- assignee: -> ezio.melotti resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <

[issue17883] Fix buildbot testing of Tkinter

Roundup Robot added the comment: New changeset 3c58fa7dc7f1 by Ezio Melotti in branch '2.7': #17883: Fix buildbot testing of Tkinter on Windows. Patch by Zachary Ware. http://hg.python.org/cpython/rev/3c58fa7dc7f1 -- nosy: +python-dev ___ Python trac

[issue17883] Fix buildbot testing of Tkinter

Changes by Ezio Melotti : -- nosy: +roger.serwy stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue17883] Fix buildbot testing of Tkinter

New submission from Zachary Ware: Ezio, you brought up the fact that the 2.7 Windows buildbots were skipping the Tkinter tests in Terry's core-mentorship thread about tkinter on Windows last month, and I've finally learned what is causing that failure. It appears that when 689a813f4afc and df