[issue17807] Generator cleanup without tp_del

2013-05-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Obsoleted by PEP 442. -- resolution: -> rejected status: open -> closed ___ Python tracker ___ ___

[issue17807] Generator cleanup without tp_del

2013-05-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: After getting some private feedback from Guido, I'm convinced this patch isn't ready for consumption. Objects visible from the frame when it is finalized can be in a weird, incomplete state (Guido reports failing to get the __class__ of an object, for instance

[issue17807] Generator cleanup without tp_del

2013-05-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset edefd3450834 by Antoine Pitrou in branch 'default': Backout c89febab4648 following private feedback by Guido. http://hg.python.org/cpython/rev/edefd3450834 -- ___ Python tracker

[issue17807] Generator cleanup without tp_del

2013-05-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: Committing for now, we'll see what people say. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue17807] Generator cleanup without tp_del

2013-05-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset c89febab4648 by Antoine Pitrou in branch 'default': Issue #17807: Generators can now be finalized even when they are part of a reference cycle. http://hg.python.org/cpython/rev/c89febab4648 -- nosy: +python-dev

[issue17807] Generator cleanup without tp_del

2013-05-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: Updated patch keeping PyGen_NeedsFinalizing() for backwards compatibility (always returning 0). -- Added file: http://bugs.python.org/file30175/gen4.patch ___ Python tracker _

[issue17807] Generator cleanup without tp_del

2013-04-21 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue17807] Generator cleanup without tp_del

2013-04-21 Thread Phil Connell
Changes by Phil Connell : -- nosy: +isoschiz, pconnell -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17807] Generator cleanup without tp_del

2013-04-20 Thread Nick Coghlan
Nick Coghlan added the comment: Just a couple of minor comments on review. Everything else I looked for (including the path where a generator failing to stop during frame deallocation leads to reporting an unraisable exception) seemed fine. One aspect I find interesting is that we've had other

[issue17807] Generator cleanup without tp_del

2013-04-20 Thread Antoine Pitrou
Antoine Pitrou added the comment: Patch with added tests. -- Added file: http://bugs.python.org/file29962/gen3.patch ___ Python tracker ___ __

[issue17807] Generator cleanup without tp_del

2013-04-20 Thread Antoine Pitrou
Changes by Antoine Pitrou : Added file: http://bugs.python.org/file29960/gen2.patch ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue17807] Generator cleanup without tp_del

2013-04-20 Thread Antoine Pitrou
Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file29959/gen2.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17807] Generator cleanup without tp_del

2013-04-20 Thread Antoine Pitrou
New submission from Antoine Pitrou: This experimental patch proposes to defer generator cleanup to the frame itself. In this scheme, the generator frame's tp_clear throws the GeneratorExit if necessary, so as to call cleanup code. The generator doesn't have any tp_del anymore, as it is now imp