[issue17806] Add keyword args support to str/bytes.expandtabs()

Changes by Ezio Melotti : -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue17806] Add keyword args support to str/bytes.expandtabs()

Roundup Robot added the comment: New changeset 82b58807f481 by Ezio Melotti in branch 'default': #17806: Added keyword-argument support for "tabsize" to str/bytes.expandtabs(). http://hg.python.org/cpython/rev/82b58807f481 -- nosy: +python-dev ___ Pyt

[issue17806] Add keyword args support to str/bytes.expandtabs()

Serhiy Storchaka added the comment: Ezio, you can commit the patch if you want. -- stage: patch review -> commit review ___ Python tracker ___ ___

[issue17806] Add keyword args support to str/bytes.expandtabs()

Mark Dickinson added the comment: > For me s.expandtabs(3) looks more readable than s.expandtabs(tabsize=3). I disagree: I think the second is more readable, and I think it's especially helpful to those not intimately familiar with the language (which probably accounts for the vast majority o

[issue17806] Add keyword args support to str/bytes.expandtabs()

Serhiy Storchaka added the comment: > FTR the reason to add this is consistency This always was a weak reason. > and readability It is a matter of taste. For me s.expandtabs(3) looks more readable than s.expandtabs(tabsize=3). I don't see an urgent need for this feature and don't like a comp

[issue17806] Add keyword args support to str/bytes.expandtabs()

Ezio Melotti added the comment: Without patch: $ ./python -m timeit -s 'et = "a\tb\tc\td\te".expandtabs' 'et()' 100 loops, best of 3: 0.672 usec per loop $ ./python -m timeit -s 'et = "a\tb\tc\td\te".expandtabs' 'et(4)' 100 loops, best of 3: 0.744 usec per loop $ ./python -m timeit -s 'et

[issue17806] Add keyword args support to str/bytes.expandtabs()

Serhiy Storchaka added the comment: Note that adding support of keyword arguments significant slowdown argument parsing. Please measure time of the function call with and without the patch. I object to add support for keyword arguments in a quick built-in functions. Especially if it's the only

[issue17806] Add keyword args support to str/bytes.expandtabs()

Éric Araujo added the comment: Where is the “Approve patch” button :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue17806] Add keyword args support to str/bytes.expandtabs()

Changes by Ezio Melotti : -- nosy: +eric.araujo, mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17806] Add keyword args support to str/bytes.expandtabs()

New submission from Ezio Melotti: The attached patch adds keyword args support to str/bytes.expandtabs(): >>> 'a\tb'.expandtabs(tabsize=8) 'a b' >>> b'a\tb'.expandtabs(tabsize=8) b'a b' -- assignee: ezio.melotti components: Interpreter Core files: expandtabs.diff keywords: pa