[issue17699] Fix test_getpass on Windows

2013-04-12 Thread Zachary Ware
Zachary Ware added the comment: Buildbots look happy (with test_getpass, anyway) and my machine is happy too. Thanks for the commit :) -- ___ Python tracker ___ ___

[issue17699] Fix test_getpass on Windows

2013-04-11 Thread R. David Murray
R. David Murray added the comment: I'm going to close this because the windows buildbots currently aren't building, and I'll forget to close it if I wait for them. I trust you'll reopen it if it doesn't actually fix the problem for some reason :) -- resolution: -> fixed stage: -> co

[issue17699] Fix test_getpass on Windows

2013-04-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset c84a5e5f73c3 by R David Murray in branch 'default': #17699: Fix the new getpass test failures on windows. http://hg.python.org/cpython/rev/c84a5e5f73c3 -- nosy: +python-dev ___ Python tracker

[issue17699] Fix test_getpass on Windows

2013-04-11 Thread R. David Murray
R. David Murray added the comment: Thanks Zachary. I forgot to check the buildbots after I pushed that patch. -- ___ Python tracker ___ _

[issue17699] Fix test_getpass on Windows

2013-04-11 Thread Zachary Ware
New submission from Zachary Ware: (Copied the nosy list from issue17484) The new test module fails on Windows due to the lack of termios and pwd modules. Here's a patch that fixes things. I suspect the skip condition on UnixGetpassTest could be changed to check 'termios' rather than os.name,