[issue17689] Fix test discovery for test_tarfile.py

Zachary Ware added the comment: Superseded by issue18223. -- resolution: -> duplicate status: open -> closed ___ Python tracker ___ _

[issue17689] Fix test discovery for test_tarfile.py

Changes by Ezio Melotti : -- stage: -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue17689] Fix test discovery for test_tarfile.py

Zachary Ware added the comment: >> should I just add a requires_gzip to test.support and use those three >> in test_tarfile? > I think that's reasonable for now -- we can always refactor it later > and replace them with a skip_unless_module() Here's a patch :) -- Added file: http://bu

[issue17689] Fix test discovery for test_tarfile.py

Ezio Melotti added the comment: > I found requires_bz2 and requires_lzma that already exist; There's also requires_zlib. import_module is also somewhat similar, but it's used to skip the whole test file when the module is missing. > Here's another thought; would it be more useful to have a ge

[issue17689] Fix test discovery for test_tarfile.py

Zachary Ware added the comment: That is indeed simpler than what I wrote, and it does work as expected. But, is it preferable to do it this way, or with Ezio's suggested method (``skip_unless_gzip = unittest.skipUnless(gzip, "gzip not available")``, and for bz2 and lzma)? I can see merits to

[issue17689] Fix test discovery for test_tarfile.py

Antoine Pitrou added the comment: Wouldn't it be simpler to write (untested): def skipUnlessCompressionModule(name): """ Skip if the specified compression module is not available. Must e a string, currently any of 'gzip', 'bz2', or 'lzma'. """ return unittest.skipUnless(glob

[issue17689] Fix test discovery for test_tarfile.py

Changes by Zachary Ware : Added file: http://bugs.python.org/file29779/test_tarfile_discovery.v2.diff ___ Python tracker ___ ___ Python-bugs-l

[issue17689] Fix test discovery for test_tarfile.py

New submission from Zachary Ware: Here's a patch for test_tarfile.py discovery. There are a couple of inheritance issues resolved; CommonReadTest (and its children, MiscReadTest and StreamReadTest) are changed simply to avoid running the tests in CommonReadTest on their own--they pass, but are