[issue17657] IDLE: about dialog should report the full version of TK

2013-04-08 Thread Roger Serwy
Roger Serwy added the comment: Let's discuss improving the about dialog on idle-dev or in a new issue. Thanks for the patch, Todd! -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue17657] IDLE: about dialog should report the full version of TK

2013-04-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9b6de25c6054 by Roger Serwy in branch '2.7': #17657: Show full Tk version in IDLE's about dialog. http://hg.python.org/cpython/rev/9b6de25c6054 New changeset 769699f0a760 by Roger Serwy in branch '3.3': #17657: Show full Tk version in IDLE's about d

[issue17657] IDLE: about dialog should report the full version of TK

2013-04-07 Thread Ned Deily
Ned Deily added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mai

[issue17657] IDLE: about dialog should report the full version of TK

2013-04-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: At some point, I would like us to review the whole 'about' dialog, but this should be done now. It even simplifies the code. I will test and apply this week if Roger doesn't. -- stage: patch review -> commit review

[issue17657] IDLE: about dialog should report the full version of TK

2013-04-07 Thread Roger Serwy
Roger Serwy added the comment: LGTM. The patch works on Arch Linux, returning 8.5.13 which is what I have installed. -- stage: -> patch review type: behavior -> enhancement versions: +Python 3.3 ___ Python tracker

[issue17657] IDLE: about dialog should report the full version of TK

2013-04-07 Thread Todd Rovito
Changes by Todd Rovito : -- nosy: +ned.deily, roger.serwy, terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue17657] IDLE: about dialog should report the full version of TK

2013-04-07 Thread Todd Rovito
Todd Rovito added the comment: Attached is a patch the works for both Python 3.4 and Python 2.7. I have tested this patch on OS X and Windows. The code actually came from macosxSupport.py function tkVersionWarning. -- keywords: +patch Added file: http://bugs.python.org/file29724/176

[issue17657] IDLE: about dialog should report the full version of TK

2013-04-07 Thread Todd Rovito
New submission from Todd Rovito: The IDLE about dialog does not report the full version of TK. For instance it will report "8.5" and not report the last minor version number such as "8.5.9". On the Mac OS X this is problematic (but it could be a problem on other platforms) because Apple ship