[issue17654] IDLE only customizes correctly for OS X when using framework build

Ned Deily added the comment: Thanks for the review, Terry. The reasons for moving the menders changes are two. As noted in the comments, the menudefs were being customized early in IDLE initialization before calling Tk to create the root object and, therefore, we did not know at that point wh

[issue17654] IDLE only customizes correctly for OS X when using framework build

Roundup Robot added the comment: New changeset f551740c26b6 by Ned Deily in branch '2.7': Issue #17654: Ensure IDLE menus are customized properly on OS X for http://hg.python.org/cpython/rev/f551740c26b6 New changeset 67a7a49e7b78 by Ned Deily in branch '3.4': Issue #17654: Ensure IDLE menus are

[issue17654] IDLE only customizes correctly for OS X when using framework build

Terry J. Reedy added the comment: If I understand the Bindings.py patch, the fragility changed from "If you edit menudefs, edit the Mac block that follows" to "If you change (e sections of) menudefs, edit macosxSupport.overrideRootMenu". That seems like a wash to me, except for the narrowing d

[issue17654] IDLE only customizes correctly for OS X when using framework build

Ned Deily added the comment: If there are no objections, I'd like to commit this cleanup soon. It should make things a bit easier for people testing IDLE from development builds on OS X and fix some long-standing bugs when linking with the Tk X11 variant on OS X. -- nosy: +terry.reedy

[issue17654] IDLE only customizes correctly for OS X when using framework build

Ned Deily added the comment: (Just to be clear, the Tk situation on OS X has changed substantially since the original customizations were added by Ronald. So the checks weren't bogus initially. And I've modified some of them subsequently before understanding some of the "nuances" of the vari

[issue17654] IDLE only customizes correctly for OS X when using framework build

Ned Deily added the comment: Here's a patch that refactors many of the OS X customizations in IDLE based on more granular criteria, e.g. those that should apply to all Tk implementations vs those that depend on specific ones (Cocoa Tk, Carbon Tk, or X11 Tk) rather than the bogus current framew

[issue17654] IDLE only customizes correctly for OS X when using framework build

Ronald Oussoren added the comment: The trigger for the customizations is probably too specific. The primary reason for a having a check that's more specific than 'if sys.platform == "darwin"' is to avoid using the customizations when someone uses an X11 build of Tk and I didn't know (and still

[issue17654] IDLE only customizes correctly for OS X when using framework build

Changes by Ned Deily : -- assignee: -> ned.deily stage: -> needs patch title: IDLE: Right click menu not working on OS X -> IDLE only customizes correctly for OS X when using framework build versions: +Python 3.3 ___ Python tracker