[issue17482] functools.update_wrapper mishandles __wrapped__

Change by Eryk Sun : -- Removed message: https://bugs.python.org/msg405702 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17482] functools.update_wrapper mishandles __wrapped__

Change by Eryk Sun : -- components: -IO nosy: -ahmedsayeed1982 versions: -Python 3.9 ___ Python tracker ___ ___ Python-bugs-list

[issue17482] functools.update_wrapper mishandles __wrapped__

Ahmed Sayeed added the comment: Tentative patch: ... diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c https://www.webb-dev.co.uk/computers/crypto-apps/ index f318a125319..c20c0d7d649 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c http://www.compilatori.com/health/premium-subscription/ @@

[issue17482] functools.update_wrapper mishandles __wrapped__

Nick Coghlan added the comment: New release blocker created as issue 20684 -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17482] functools.update_wrapper mishandles __wrapped__

Nick Coghlan added the comment: Mike, could you file a new issue for that? It's a genuine regression in the inspect module. -- ___ Python tracker ___

[issue17482] functools.update_wrapper mishandles __wrapped__

mike bayer added the comment: OK well, let me just note what the issue is, and I think this is pretty backwards-incompatible, and additionally I really can't find any reasonable way of working around it except for just deleting __wrapped__. It would be nice if there were some recipe or docume

[issue17482] functools.update_wrapper mishandles __wrapped__

mike bayer added the comment: i think I found the problem. sorry for the noise. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue17482] functools.update_wrapper mishandles __wrapped__

mike bayer added the comment: this is actually biting me, I think, though I'm having a very hard time getting a small Python script to duplicate it :/. https://bitbucket.org/zzzeek/alembic/issue/175/test-suite-failure-under-python34 refers to the current problems I'm having. I am not reall

[issue17482] functools.update_wrapper mishandles __wrapped__

Nick Coghlan added the comment: I decided I can live with the risk of this biting someone in 3.3 - the combination of using multiple levels of wrapping *and* using __wrapped__ for more than merely introspection seems remote enough to make being conservative with the behavioural change the bett

[issue17482] functools.update_wrapper mishandles __wrapped__

Roundup Robot added the comment: New changeset 13b8fd71db46 by Nick Coghlan in branch 'default': Close issue 17482: don't overwrite __wrapped__ http://hg.python.org/cpython/rev/13b8fd71db46 -- nosy: +python-dev resolution: -> fixed stage: test needed -> committed/rejected status: open -

[issue17482] functools.update_wrapper mishandles __wrapped__

Changes by Łukasz Langa : -- nosy: +lukasz.langa ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue17482] functools.update_wrapper mishandles __wrapped__

Nick Coghlan added the comment: Georg, just a heads up that I was informed of a fairly significant bug in the __wrapped__ handling which some folks doing function introspection had been assuming was a feature. I'd like to fix it for 3.3.3, but need your +1 as RM since it *will* break introspe

[issue17482] functools.update_wrapper mishandles __wrapped__

Changes by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue17482] functools.update_wrapper mishandles __wrapped__

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue17482] functools.update_wrapper mishandles __wrapped__

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue17482] functools.update_wrapper mishandles __wrapped__

Nick Coghlan added the comment: OK, thinking about this a little further, I think it's not as bad as I feared. The number of people likely to be introspecting __wrapped__ is quite small, and updating to the correct recursive code will still do the right thing in existing versions. So long as

[issue17482] functools.update_wrapper mishandles __wrapped__

Nick Coghlan added the comment: And as further evidence that I always intended this to be a wrapper chain: issue 13266 :) -- ___ Python tracker ___ _

[issue17482] functools.update_wrapper mishandles __wrapped__

Nick Coghlan added the comment: There's an interesting backwards compatibility challenge here. We definitely need to fix the misbehaviour, since it can lead to some pretty serious bugs in user code when attempting to bypass the LRU cache decorator if the wrapped function itself had a __wrapped