[issue1736] Three bugs of FCICreate (PC/_msi.c)

Martin v. Löwis added the comment: Thanks for the patch. Committed as r60743 and r60744. -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ __

[issue1736] Three bugs of FCICreate (PC/_msi.c)

Hirokazu Yamamoto added the comment: Refactored a little. More clean diff. Added file: http://bugs.python.org/file9398/_msi.patch __ Tracker <[EMAIL PROTECTED]> __

[issue1736] Three bugs of FCICreate (PC/_msi.c)

Hirokazu Yamamoto added the comment: Umm, please forget previous comment. >>> msilib.FCICreate("a" * 256 + "/" + "b" * 255, []) crashed on debug build. (CB_MAX_CAB_PATH == 256) -- title: Two bugs of FCICreate (PC/_msi.c) -> Three bugs of FCICreate (PC/_msi.c) ___

[issue1736] Three bugs of FCICreate (PC/_msi.c)

Hirokazu Yamamoto added the comment: Sorry, I lied. What I said in bug 2 was totally wrong. Meaning of 'i' was changed from original code and my patch. There is no problem about buffer length. Thank you. __ Tracker <[EMAIL PROTECTED]>

[issue1736] Three bugs of FCICreate (PC/_msi.c)

Changes by Christian Heimes: -- assignee: -> loewis components: +Windows keywords: +patch, py3k nosy: +loewis priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ __

[issue1736] Three bugs of FCICreate (PC/_msi.c)

New submission from Hirokazu Yamamoto: I have fixed three bugs of msilib.FCICreate() 1. msilib.FCICreate("a.cab") creates ".a.cab" (extra leading dot) In recent cab SDK's FCI-FDI.doc, # quote start The szCab field should contain a string which contains the name of the first cabinet to be cre