[issue1710703] zipfile.ZipFile behavior inconsistent.

Georg Brandl added the comment: Not sure what you're referring to, all occurrences of BadZipfile (except for its definition and its documentation) have been removed in py3k. -- ___ Python tracker __

[issue1710703] zipfile.ZipFile behavior inconsistent.

Boštjan Mejak added the comment: Please fix this patch to raise BadZipFile instead of BadZipfile. See http://docs.python.org/dev/library/zipfile.html?highlight=zipfile#zipfile.BadZipfile. The use of the class name BadZipfile is deprecated. The class name BadZipFile is prefered. -- no

[issue1710703] zipfile.ZipFile behavior inconsistent.

Georg Brandl added the comment: Okay, applied as r85455. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue1710703] zipfile.ZipFile behavior inconsistent.

Changes by Alan McIntyre : Removed file: http://bugs.python.org/file18534/zipfile_empty2.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue1710703] zipfile.ZipFile behavior inconsistent.

Alan McIntyre added the comment: My apologies if Georg was waiting on me to say, "Yes." :-) I've attached an updated patch that has the NEWS/doc changes Antoine mentioned. I also just checked that the tests still pass on Linux against the current trunk, and that the docs still build properly

[issue1710703] zipfile.ZipFile behavior inconsistent.

Changes by Alan McIntyre : Removed file: http://bugs.python.org/file9144/empty-zipfile.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue1710703] zipfile.ZipFile behavior inconsistent.

Mark Lawrence added the comment: I don't think the latest patch has been committed, could someone wave their magic wand please :) -- nosy: +BreamoreBoy ___ Python tracker ___

[issue1710703] zipfile.ZipFile behavior inconsistent.

Georg Brandl added the comment: Agreed with Antoine. Do you want to commit? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue1710703] zipfile.ZipFile behavior inconsistent.

Antoine Pitrou added the comment: Two nits: - bug fixes shouldn't have a "versionadded" or "versionchanged" entry (it's only for new features) - Misc/NEWS should be in antichronological order -- nosy: +pitrou ___ Python tracker

[issue1710703] zipfile.ZipFile behavior inconsistent.

Alan McIntyre added the comment: Apparenty _EndRecData64 needed the same kind of check that _EndRecData has when trying to seek to the end-of-archive record. So I added that, and everything seems to work correctly now. All tests pass on my 64-bit Linux box (including test_zipfile64). The u

[issue1710703] zipfile.ZipFile behavior inconsistent.

Alan McIntyre added the comment: Sure thing; I'll see if I can have a look within the next week or so. -- ___ Python tracker ___ __

[issue1710703] zipfile.ZipFile behavior inconsistent.

Georg Brandl added the comment: Alan, I've updated the patch for current 3.2 trunk, see attached, but the new test now fails. Can you find out why? -- nosy: +georg.brandl versions: +Python 3.2 -Python 2.7 Added file: http://bugs.python.org/file18257/zipfile_empty.diff ___

[issue1710703] zipfile.ZipFile behavior inconsistent.

Changes by Ezio Melotti : -- keywords: +patch stage: -> test needed type: -> behavior versions: +Python 2.7 -Python 2.5 ___ Python tracker ___ ___

[issue1710703] zipfile.ZipFile behavior inconsistent.

Alan McIntyre added the comment: Here's a quick patch that covers the issues mentioned in my post from 2007-05-09. Added file: http://bugs.python.org/file9144/empty-zipfile.diff _ Tracker <[EMAIL PROTECTED]> _