[issue16790] provide ability to share tests between int and long tests

Chris Jerdonek added the comment: Thanks for the reviews, Serhiy. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue16790] provide ability to share tests between int and long tests

Roundup Robot added the comment: New changeset eb1734e579f7 by Chris Jerdonek in branch '2.7': Issue #16790: add some of the recent issue #16045 int tests to test_long. http://hg.python.org/cpython/rev/eb1734e579f7 -- nosy: +python-dev ___ Python trac

[issue16790] provide ability to share tests between int and long tests

Serhiy Storchaka added the comment: LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue16790] provide ability to share tests between int and long tests

Chris Jerdonek added the comment: After this issue, the ordering of new test_int test cases in 3.x should preferably match the ordering in 2.7 for easier back-porting when the tests are new in both. For example, test_no_args() and test_keyword_args() could go at the top of 3.x's IntTestCases.

[issue16790] provide ability to share tests between int and long tests

Chris Jerdonek added the comment: Note that we need to be more careful about checking for duplicate test names now. -- Added file: http://bugs.python.org/file28451/issue-16790-2-27.patch ___ Python tracker ___

[issue16790] provide ability to share tests between int and long tests

Chris Jerdonek added the comment: Good point. New patch coming shortly. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue16790] provide ability to share tests between int and long tests

Serhiy Storchaka added the comment: Why not inherit IntTestCases and LongTest from SharedTestCaseMixin? And looks as CommonSomeTest naming is more common than SharedSomeTest. -- components: +Tests -Interpreter Core nosy: +serhiy.storchaka stage: -> patch review type: -> enhancement _

[issue16790] provide ability to share tests between int and long tests

Chris Jerdonek added the comment: Attaching patch. The tests moved to SharedTestCaseMixin in this patch are tests that were very recently added (as part of issue 16045) and that are planned on being added to test_long as part of issue 16784. -- keywords: +patch Added file: http://bugs

[issue16790] provide ability to share tests between int and long tests

New submission from Chris Jerdonek: Currently, adding new int() and long() tests that are common to both requires duplicating the tests in both test_int and test_long, which makes the tests harder to review and maintain and keep in synch. Providing a simple way to share tests between test_int