[issue16764] Make zlib accept keyword-arguments

Changes by Martin Panter : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue16764] Make zlib accept keyword-arguments

Xiang Zhang added the comment: I think it's okay to close now. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue16764] Make zlib accept keyword-arguments

Martin Panter added the comment: All the interesting keyword arguments seem to work now (checking against my notes from earlier). Is there anything else anyone wants to do, or can we close this now? -- stage: commit review -> resolved ___ Python tra

[issue16764] Make zlib accept keyword-arguments

Serhiy Storchaka added the comment: > Serhiy, the message added in Misc/NEWS should be in Library section not Core > and Builtins section. Done. And addressed Victor's reasonable comment. Thanks! -- ___ Python tracker

[issue16764] Make zlib accept keyword-arguments

Roundup Robot added the comment: New changeset ab0039b8a80e by Serhiy Storchaka in branch 'default': Issue #16764: Move NEWS entry to correct section and remove too strict test. https://hg.python.org/cpython/rev/ab0039b8a80e -- ___ Python tracker

[issue16764] Make zlib accept keyword-arguments

STINNER Victor added the comment: Oops, I reviewed the patch before seeing that Serhiy already pushed it :-) Ignore my comment. -- nosy: +haypo ___ Python tracker ___ __

[issue16764] Make zlib accept keyword-arguments

Xiang Zhang added the comment: Serhiy, the message added in Misc/NEWS should be in Library section not Core and Builtins section. -- ___ Python tracker ___ _

[issue16764] Make zlib accept keyword-arguments

Changes by Serhiy Storchaka : -- assignee: serhiy.storchaka -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16764] Make zlib accept keyword-arguments

Xiang Zhang added the comment: Oops! I am on the way regenerating the CA output to catch up with hg tip, but after a meeting you have done it. Thanks for your work, Serhiy. And excellent job as for issue27574. -- ___ Python tracker

[issue16764] Make zlib accept keyword-arguments

Roundup Robot added the comment: New changeset a4101218364e by Serhiy Storchaka in branch 'default': Issue #16764: Support keyword arguments to zlib.decompress(). Patch by https://hg.python.org/cpython/rev/a4101218364e -- nosy: +python-dev ___ Python

[issue16764] Make zlib accept keyword-arguments

Serhiy Storchaka added the comment: LGTM. With issue27574 the overhead is even smaller. -- assignee: -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker

[issue16764] Make zlib accept keyword-arguments

Xiang Zhang added the comment: OK. Simplest test with positional arguments. Without patch: ./python -m timeit -s 'import zlib; a = zlib.compress(b"abcdefghijklmnopqrstuvwxyz")' 'zlib.decompress(a, 15, 16384)' 100 loops, best of 3: 0.841 usec per loop ./python -m timeit -s 'import zlib; a

[issue16764] Make zlib accept keyword-arguments

Serhiy Storchaka added the comment: Xiang Zhang, could you please provide results of benchmarking zlib.decompress and decompressobj.decompress in simplest case with and without the patch? PyArg_ParseTupleAndKeywords can be slower than PyArg_ParseTuple even for positional arguments, and we shou

[issue16764] Make zlib accept keyword-arguments

Martin Panter added the comment: Xiang’s patch looks okay from a correctness point of view -- ___ Python tracker ___ ___ Python-bugs-l

[issue16764] Make zlib accept keyword-arguments

Xiang Zhang added the comment: I agree with Martin and suggest make the following changes: 1. Make wbits and bufsize of zlib.decompress keyword arguments. 2. Make max_length of decompressobj.decompress keyword argument. I'd prefer others to stay position-only as now. Attach a patch doing the a

[issue16764] Make zlib accept keyword-arguments

Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue16764] Make zlib accept keyword-arguments

Serhiy Storchaka added the comment: PyArg_ParseTupleAndKeywords() and Argument Clinic now support positional-only arguments. Thus this my objection can be resolved. But performance argument still needs an investigation. In any case the patch needs updating, since the zlib module was rewritten

[issue16764] Make zlib accept keyword-arguments

Stéphane Wirtel added the comment: martin or serhiy, can we move this issue to 3.6 ? -- nosy: +matrixise ___ Python tracker ___ ___ P

[issue16764] Make zlib accept keyword-arguments

Martin Panter added the comment: See Issue 8706 discussing adding keyword support to library functions in general. Functions the first patch affects: * zlib.compress(data, level=...): still relevant; see Issue 26243 * compressobj(memlevel=...): fixed in documentation in revision fdb5d84f9948

[issue16764] Make zlib accept keyword-arguments

Serhiy Storchaka added the comment: Sorry, I missed, not decompress(), but compress(). Except this small error all of what I said *is* a problem of this patch. -- components: +Extension Modules -Library (Lib) type: -> enhancement ___ Python tracker

[issue16764] Make zlib accept keyword-arguments

Lukas Lueg added the comment: Nothing of what you mention is a problem of this patch. The memLevel-keyword was not supported as of now, only the docstring ("memLevel") and the documentation ("memlevel") mentioned it. There is no third-party code that could have used it. The current docstring

[issue16764] Make zlib accept keyword-arguments

Serhiy Storchaka added the comment: I don't think it worth to add support of keyword for the first mandatory argument. This can freeze the poor and inconsistent () names. For example compress()/decompress() methods of bz2 and lzma objects doesn't support keyword arguments. And why you use "str

[issue16764] Make zlib accept keyword-arguments

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue16764] Make zlib accept keyword-arguments

Lukas Lueg added the comment: Attaching a patch to fix all pep8/pyflakes warnings and errors in test_zlib.py -- Added file: http://bugs.python.org/file28419/zlib_tests_pep8.patch ___ Python tracker

[issue16764] Make zlib accept keyword-arguments

New submission from Lukas Lueg: The patch "zlib_keywords.patch" makes zlib's classes and functions accept keyword arguments as documented. It also fixes two cases in which the docstring differ from the documentation (decompress(data) vs. decompress(string) and compressobj(memlevel) vs. compres