[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Richard Oudkerk
Changes by Richard Oudkerk : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Richard Oudkerk
Richard Oudkerk added the comment: > Perhaps NEWS item needed for this change. Done. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 82db097cd2e0 by Richard Oudkerk in branch '2.7': Add Misc/NEWS entry for Issue #16743 http://hg.python.org/cpython/rev/82db097cd2e0 New changeset efe489f87881 by Richard Oudkerk in branch '3.2': Add Misc/NEWS entry for Issue #16743 http://hg.python.

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps NEWS item needed for this change. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset b1bbe519770b by Richard Oudkerk in branch '2.7': Issue #16743: Fix mmap overflow check on 32 bit Windows http://hg.python.org/cpython/rev/b1bbe519770b New changeset c2c84d3ab393 by Richard Oudkerk in branch '3.2': Issue #16743: Fix mmap overflow che

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-12 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-01-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: I missed the Ngb+1 case in your previous answer and agree that this is a bug issue. -- ___ Python tracker ___ _

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-01-27 Thread Richard Oudkerk
Richard Oudkerk added the comment: On 27/01/2013 9:06pm, Serhiy Storchaka wrote: > Every bugfix breaks some code. As a compromise I propose set > m_obj->size = PY_SSIZE_T_MAX in case of overflow and emit a warning. Trying to allocate PY_SSIZE_T_MAX bytes always seems to fail with WindowsE

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-01-27 Thread Richard Oudkerk
Richard Oudkerk added the comment: On 27/01/2013 8:27pm, Terry J. Reedy wrote: > I agree we do not need to retain unpredictable 'dumb luck' -- in > future versions. But in the absence of a clear discrepancy > between doc and behavior (the definition of a bug) I believe > breaking such code in a b

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-01-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Every bugfix breaks some code. As a compromise I propose set m_obj->size = PY_SSIZE_T_MAX in case of overflow and emit a warning. -- ___ Python tracker _

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-01-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: > As Richard explained, this will not break working code, this will break only > broken code If code is both working and broken, for some reasonable meaning of 'working' and 'broken', breaking such broken code *will* break working code. I understood Richard a

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-01-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Let's go ahead. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2012-12-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: As Richard explained, this will not break working code, this will break only broken code. Working limit will not be changed, it's sys.maxsize on all platforms. -- ___ Python tracker

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2012-12-26 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2012-12-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: New data, new thoughts ;-) I agree that an undocumented discrepancy between Windows and *nix should be fixed either in doc, code, or both. The fix might be version specific. If the limit on Windows is less than it should or could be, because of our code, that

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2012-12-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Sorry, I had missed you reuse an existing test. It's right. I think decreasing file size to 4 GiB + 1 byte will keep the purpose of the test and save a little time, but this is another issue. Let's go ahead! -- __

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2012-12-26 Thread Richard Oudkerk
Changes by Richard Oudkerk : -- title: mmap accepts files > 1 GB, but processes only 1 GB -> mmap on Windows can mishandle files larger than sys.maxsize type: enhancement -> behavior ___ Python tracker ___