[issue16715] Get rid of IOError. Use OSError instead

Terry J. Reedy added the comment: I would wait and see if it happens gain or on other buildbots. As I am sure you know, intermittent failures, not reproducible on demand, are nasty. -- ___ Python tracker _

[issue16715] Get rid of IOError. Use OSError instead

koobs added the comment: Apologies for the noise Terry, rebuilding passes. Unsetting versions: 3.3 Is the failure on the build I reported worth opening an issue for? -- versions: -Python 3.3 ___ Python tracker

[issue16715] Get rid of IOError. Use OSError instead

Terry J. Reedy added the comment: I don't think so. The idle test, test_idle, passed. The patch did not even affect any of the three idle files that it currently tests. Just because a commit triggers a test does not mean that it is the cause of any failure that happens. The log says the failur

[issue16715] Get rid of IOError. Use OSError instead

koobs added the comment: Commit to 3.3 broke at least my FreeBSD buildbot: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%20dtrace%203.3/builds/641/steps/test/logs/stdio Also setting +Version: Python 3.3 on this. -- nosy: +koobs versions: +Python 3.3 ___

[issue16715] Get rid of IOError. Use OSError instead

Roundup Robot added the comment: New changeset 2fe64ce5da05 by Terry Jan Reedy in branch '3.3': #18151, part 1: Backport idlelilb portion of Andrew Svetlov's 3.4 patch http://hg.python.org/cpython/rev/2fe64ce5da05 -- ___ Python tracker

[issue16715] Get rid of IOError. Use OSError instead

Terry J. Reedy added the comment: Now that 3.2 is off of maintenance and Idle patches are being applied to both 3.3 and 3.4 (and usually 2.7), I plan to backport the Idle subset of changes to 3.3 so patches are more likely to merge forward without incident. (I have already done one where this

[issue16715] Get rid of IOError. Use OSError instead

Éric Araujo added the comment: Source code says: # derives from OSError for backwards-compatibility with Python 2.4.0 class LoadError(OSError): pass In 3.0, LoadError could have been made a direct subclass of Exception. Now it’s too late, but a best practice IMO would still be to write LoadEr

[issue16715] Get rid of IOError. Use OSError instead

Andrew Svetlov added the comment: Please email python-dev if you think LoadError should be directly specified. -- ___ Python tracker ___ _

[issue16715] Get rid of IOError. Use OSError instead

py.user added the comment: Zen: Explicit is better than implicit. In the face of ambiguity, refuse the temptation to guess. I assume that someone changes the LoadError class and goes into the revert function. How he can figure out that the cookies should return to the previous state if LoadErr

[issue16715] Get rid of IOError. Use OSError instead

Andrew Svetlov added the comment: LoadError was IOError descendant, now OSError is directly specified. If somebody want to change base class for LoadError he should to update the code in several places in http/cookiejar.py. The docstring for FileCookieJar.revert directly specifies possible excep

[issue16715] Get rid of IOError. Use OSError instead

py.user added the comment: Andrew Svetlov wrote: > LoadError is inherited from OSError the comment for the function doesn't tell it today it's inherited from OSError and tomorrow it may inherit from ANYError -- ___ Python tracker

[issue16715] Get rid of IOError. Use OSError instead

Andrew Svetlov added the comment: It's not a typo. 1. LoadError is inherited from OSError so LoadError exception is also caught. 2. Pointed code just resets cookie state and reraises exception, exception type is saved. The code is correct from my perspective. -- __

[issue16715] Get rid of IOError. Use OSError instead

py.user added the comment: found a typo (removed LoadError) commit 80f2b1273e8c0e1a28fabe537ae9c5acbbcee187 Author: Andrew Svetlov Date: Tue Dec 25 16:47:37 2012 +0200 Replace IOError with OSError (#16715) ... diff --git a/Lib/http/cookiejar.py b/Lib/http/cookiejar.py index a77dc3f

[issue16715] Get rid of IOError. Use OSError instead

New submission from Roundup Robot: New changeset 7d69d04522e3 by Andrew Svetlov in branch 'default': Replace IOError with OSError (#16715) http://hg.python.org/cpython/rev/7d69d04522e3 -- nosy: +python-dev ___ Python tracker

[issue16715] Get rid of IOError. Use OSError instead

Andrew Svetlov added the comment: Fixed. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue16715] Get rid of IOError. Use OSError instead

Changes by Antoine Pitrou : -- title: Get rid of IOrror. Use OSError instead -> Get rid of IOError. Use OSError instead ___ Python tracker ___ __