[issue1664] nntplib is not IPv6-capable

Derek Morr added the comment: Thanks. Is there any chance of getting bug 1655 fixed as well? imaplib has the same issue as nntplib, and the patch is identical. -- ___ Python tracker __

[issue1664] nntplib is not IPv6-capable

Antoine Pitrou added the comment: Your patch is committed in r72640. Thanks! -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue1664] nntplib is not IPv6-capable

Antoine Pitrou added the comment: Assuming the patch does work, +1 for applying it. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue1664] nntplib is not IPv6-capable

Chris Morrow added the comment: This is a little silly and painful... it's utterly broken to hardcode the AF type in this way, could we please apply a patch (something like the proposed seems to work fine) and get this rolled into the next release? It seems really lame to not be able to suppor

[issue1664] nntplib is not IPv6-capable

Derek Morr added the comment: I'm confused by that. In order to apply a 3 line patch (which replaces one standard library function with another), you want an entire test suite written for nntplib? If we're willing to accept that nttplib works reasonably well now, why is the testsuite necess

[issue1664] nntplib is not IPv6-capable

STINNER Victor added the comment: @dmorr: It would be faster if nntplib has some tests :-/ -- ___ Python tracker ___ ___ Python-bugs-l

[issue1664] nntplib is not IPv6-capable

Derek Morr added the comment: Any chance of this being applied soon? It's been sitting in the bugtracker for over a year now. -- ___ Python tracker ___ _

[issue1664] nntplib is not IPv6-capable

Antoine Pitrou added the comment: I was going to suggest writing a test but I see that nntplib hasn't got a single unit test :-O -- nosy: +pitrou ___ Python tracker ___ _

[issue1664] nntplib is not IPv6-capable

Chris Morrow added the comment: Are we sure that the 2.6 fix (in the patch) will make it into 2.6? (and the right upstream patching will happen to the 3.0 code as well?) ___ Python tracker _

[issue1664] nntplib is not IPv6-capable

STINNER Victor added the comment: About Python 2.5: this branch doesn't accept bugfix anymore, only security issues. So only Python 2.6+ and 3.0+ can be patched. ___ Python tracker ___ _

[issue1664] nntplib is not IPv6-capable

STINNER Victor added the comment: I like nntplib_ipv6.patch: it's a generic solution (may support address families other than IPv6) and reuse code (socket.create_connection()) is always a good thing :-) -- nosy: +haypo ___ Python tracker

[issue1664] nntplib is not IPv6-capable

Chris Morrow added the comment: a possible fix for 2.5 is: morr...@tweezer:/tmp$ diff -U3 nntplib.py.orig nntplib.py --- nntplib.py.orig 2008-12-30 01:06:14.0 -0500 +++ nntplib.py 2008-12-30 01:07:33.0 -0500 @@ -109,8 +109,19 @@ """ self.host = host

[issue1664] nntplib is not IPv6-capable

Chris Morrow added the comment: oy, and I'm not reading emails properly. I'll try the fix you propose for 2.5. ___ Python tracker ___ ___ Pyth

[issue1664] nntplib is not IPv6-capable

Chris Morrow added the comment: oh crap :( I saw the 2.6 AFTER I posted the message :( sorry. grr, have to find a fix for 2.5 I suppose now. Thanks. ___ Python tracker ___ _

[issue1664] nntplib is not IPv6-capable

Derek Morr added the comment: Yes. The patch is against 2.6. It uses the socket.create_connection() helper function, which was added in 2.6. See http://svn.python.org/view? rev=54546&view=rev for the commit message. If you really want to apply it to 2.5, it's trivial to adapt the patch. Just

[issue1664] nntplib is not IPv6-capable

Chris Morrow added the comment: This patch doesn't appear to work for python2.5.1 -> Python 2.5.1 (r251:54863, Jun 15 2008, 18:24:51) [GCC 4.3.0 20080428 (Red Hat 4.3.0-8)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> from nntplib import NNTP >>> conn =

[issue1664] nntplib is not IPv6-capable

Changes by Christian Heimes: -- keywords: +patch priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsub

[issue1664] nntplib is not IPv6-capable

Changes by Giampaolo Rodola': -- nosy: +giampaolo.rodola __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1664] nntplib is not IPv6-capable

New submission from Derek Morr: nntplib hardcodes AF_INET for the socket address family. This prevents it from using IPv6. Attached is a patch that converts NNTP.__init__() to use socket.create_connection(), which is IPv6-capable. -- components: Library (Lib) files: nntplib_ipv6.patch me