[issue16626] Infinite recursion in glob.glob('*:') on Windows

Antoine Pitrou added the comment: Patches now committed, thank you ! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Roundup Robot added the comment: New changeset b0935ef48186 by Antoine Pitrou in branch '2.7': Issue #16626: Fix infinite recursion in glob.glob() on Windows when the pattern contains a wildcard in the drive or UNC path. http://hg.python.org/cpython/rev/b0935ef48186 --

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Roundup Robot added the comment: New changeset 4af260a54e05 by Antoine Pitrou in branch '3.2': Issue #16626: Fix infinite recursion in glob.glob() on Windows when the pattern contains a wildcard in the drive or UNC path. http://hg.python.org/cpython/rev/4af260a54e05 New changeset b90aa7f66e4a b

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Antoine Pitrou added the comment: > Patch updated with clarified comments. > > Are the tests fail on non-fixed Python? Yes, they do. -- ___ Python tracker ___ _

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Serhiy Storchaka added the comment: Patch updated with clarified comments. Are the tests fail on non-fixed Python? -- Added file: http://bugs.python.org/file28329/glob_magic_in_drive_2.patch ___ Python tracker ___

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Antoine Pitrou added the comment: Thank you, the new test works fine. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28323/glob_magic_in_drive_test-2.7.patch ___ Python tracker ___ ___ Py

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Serhiy Storchaka added the comment: Ah, I forgot that splitdrive() on 2.7 does not work with UNC paths. Here is an updated patch. -- Added file: http://bugs.python.org/file28324/glob_magic_in_drive_test-2.7_2.patch ___ Python tracker

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Antoine Pitrou added the comment: Tests work fine under 3.x, but under 2.7 I get: == FAIL: test_glob_magic_in_drive (test.test_glob.GlobTests) -- Traceback (mos

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file28323/glob_magic_in_drive_test-2.7.patch ___ Python tracker ___ ___ Pytho

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Serhiy Storchaka added the comment: I have made the test, but I can't run it. Therefore I can't guarantee that the test works. -- Added file: http://bugs.python.org/file28322/glob_magic_in_drive_test.patch ___ Python tracker

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Antoine Pitrou added the comment: How about adding a test? -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28221/glob_magic_in_drive.patch ___ Python tracker ___ ___ Python-bugs-

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Serhiy Storchaka added the comment: > Patch contains unrelated changes. Sorry, my fault. Here is a cleaned patch. -- Added file: http://bugs.python.org/file28314/glob_magic_in_drive.patch ___ Python tracker _

[issue16626] Infinite recursion in glob.glob('*:') on Windows

Éric Araujo added the comment: Patch contains unrelated changes. -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mai

[issue16626] Infinite recursion in glob.glob('*:') on Windows

New submission from Serhiy Storchaka: glob.glob() can fall in infinite recursion (causing stack overflow) on Windows with patterns which contains metacharacters in drive or UNC path ('*:foo', r'\\?\c:\bar'). This is my assumption, someone should confirm it on Windows. Here is a patch, which fi