[issue16612] Integrate "Argument Clinic" into CPython trunk

2014-01-14 Thread Larry Hastings
Larry Hastings added the comment: If it's not worth a new issue, then you can check it in without citing an issue at all. -- ___ Python tracker ___ _

[issue16612] Integrate "Argument Clinic" into CPython trunk

2014-01-14 Thread Meador Inge
Meador Inge added the comment: Will do, but in this case I didn't think a one character diff was worth it. -- nosy: +meador.inge ___ Python tracker ___ __

[issue16612] Integrate "Argument Clinic" into CPython trunk

2014-01-14 Thread Larry Hastings
Larry Hastings added the comment: Meador Inge: In the future, please create new issues for these sorts of fixes. -- ___ Python tracker ___ ___

[issue16612] Integrate "Argument Clinic" into CPython trunk

2014-01-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset f35b3a86ade3 by Meador Inge in branch 'default': Fix minor bug in dict.__contains__ docstring. http://hg.python.org/cpython/rev/f35b3a86ade3 -- ___ Python tracker

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch with yet some tiny changes (but they are too large for just comment). It corrects misleading docstrings of permute_*_option_groups() and simplifies rstrip_lines() and permute_optional_groups(). Fill free to apply those of them which look good

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-19 Thread Stefan Behnel
Changes by Stefan Behnel : -- nosy: -scoder ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 47618b00405b by Serhiy Storchaka in branch 'default': Fix compilation of the curses module (broken by issue #16612). http://hg.python.org/cpython/rev/47618b00405b -- ___ Python tracker

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-19 Thread koobs
koobs added the comment: _curses and _curses_panel fail to build after this commit on koobs-freebsd10 buildslave, with some lovely clang warnings too. Attaching full log here. -- nosy: +koobs Added file: http://bugs.python.org/file32217/koobs-freebsd10-py3x-build-610.log _

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-19 Thread Larry Hastings
Larry Hastings added the comment: Checked in. Thanks everybody! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8fde1a2c94dc by Larry Hastings in branch 'default': Issue #16612: Add "Argument Clinic", a compile-time preprocessor http://hg.python.org/cpython/rev/8fde1a2c94dc -- nosy: +python-dev ___ Python tracker

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-18 Thread Larry Hastings
Larry Hastings added the comment: Incorporated a small change from Antoine and a ton of small changes from Serhiy. Thanks guys! -- Added file: http://bugs.python.org/file32212/larry.clinic.patch.7.diff ___ Python tracker

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Or we could copy a page out of the PyPy playbook: generate a mandlebrot > as a comment at column 0, then put the real text at column 80+. In the > right editor you'd never see it again! That's only good if editing the file needs 3GB RAM. --

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have added a handful of nitpicks on Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > If you redirect stuff into a second file then you have way more points of failure--the files could get out sync, for example. Clinic can define a macro with a random value in a main file before including generated file and check this value by preprocessor i

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-18 Thread Larry Hastings
Larry Hastings added the comment: I played with that at one point. Guido suggested it was a bad idea. If you redirect stuff into a second file then you have way more points of failure--the files could get out sync, for example. I tend to agree. We could, however, change Clinic so it generated

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is awesome! Clinic adds too much visual garbage. Could we move all generated content into separated *_clinic.h files? -- ___ Python tracker ___

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-18 Thread Larry Hastings
Larry Hastings added the comment: Incorporated suggestions from Antoine and Berker Peksag. Thanks! -- Added file: http://bugs.python.org/file32205/larry.clinic.patch.6.diff ___ Python tracker _

[issue16612] Integrate "Argument Clinic" into CPython trunk

2013-10-17 Thread Larry Hastings
Larry Hastings added the comment: Spelling corrections from Arfrever (thanks Arfrever!), and some eentsy teensy weentsy bugfixes from me. And with a dramatic new patch number just so everybody can keep it straight. -- title: Integrate "Argument Clinic" specialized preprocessor int