[issue16324] MIMEText __init__ does not support Charset instance

2014-09-26 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Claude and thanks for the review, David! -- assignee: -> berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue16324] MIMEText __init__ does not support Charset instance

2014-09-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset d43d4d4ebf2c by Berker Peksag in branch 'default': Issue #16324: _charset parameter of MIMEText now also accepts email.charset.Charset instances. https://hg.python.org/cpython/rev/d43d4d4ebf2c -- nosy: +python-dev _

[issue16324] MIMEText __init__ does not support Charset instance

2014-09-26 Thread R. David Murray
R. David Murray added the comment: The updated patch looks good to me. Go ahead and commit it. -- ___ Python tracker ___ ___ Python-b

[issue16324] MIMEText __init__ does not support Charset instance

2014-09-26 Thread Berker Peksag
Berker Peksag added the comment: Here's an updated patch. -- nosy: +berker.peksag stage: -> patch review type: behavior -> enhancement versions: +Python 3.5 -Python 3.2 Added file: http://bugs.python.org/file36737/issue16324_v2.diff ___ Python tracke

[issue16324] MIMEText __init__ does not support Charset instance

2012-10-26 Thread Claude Paroz
Changes by Claude Paroz : -- keywords: +patch Added file: http://bugs.python.org/file27726/issue16324-1.diff ___ Python tracker ___ __

[issue16324] MIMEText __init__ does not support Charset instance

2012-10-25 Thread Claude Paroz
Claude Paroz added the comment: It's fine for me to consider it as an enhancement. The fix might be as simple as replacing **{'charset': _charset} by **{'charset': str(_charset)} in MIMEText __init__. -- ___ Python tracker

[issue16324] MIMEText __init__ does not support Charset instance

2012-10-25 Thread R. David Murray
R. David Murray added the comment: I don't think you missed anything. It doesn't look like this has ever worked, but you'd certainly think it would. The documentation doesn't claim anything about it one way or another. That probably means we should treat it as an enhancement rather than a b

[issue16324] MIMEText __init__ does not support Charset instance

2012-10-25 Thread Claude Paroz
New submission from Claude Paroz: When initializing a MIMEText instance, it might be desirable to set the _charset parameter to a real Charset instance, not only a charset identifier (for example to pass a Charset with customized body_encoding). Unfortunately, this is failing: File ".../dja