[issue16310] zipfile: allow surrogates in filenames

Changes by Ethan Furman : -- nosy: -ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue16310] zipfile: allow surrogates in filenames

Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue16310] zipfile: allow surrogates in filenames

Toshio Kuratomi added the comment: Version 2 of the patch * fixes for the style problems noted by ezio.melotti -- Added file: http://bugs.python.org/file29531/python3-zipfile-surrogate.patch ___ Python tracker ___

[issue16310] zipfile: allow surrogates in filenames

Toshio Kuratomi added the comment: Okay, here's the first version of a patch to add surrogate support to a zipfile. I think it's the minimum required to fix this bug. When archiving, if a filename contains surrogateescape'd bytes, it switches to cp437 when it saves the filename into the zipfi

[issue16310] zipfile: allow surrogates in filenames

Toshio Kuratomi added the comment: I found some "standards" docs that could bear on this: http://www.pkware.com/documents/casestudies/APPNOTE.TXT Appendix D: "D.1 The ZIP format has historically supported only the original IBM PC character encoding set, commonly referred to as IBM Code Page 43

[issue16310] zipfile: allow surrogates in filenames

STINNER Victor added the comment: > If I am the only one to think this is wrong, then so be it. > Our current workaround is to disallow surrogates in the manifest. /me shrugs. You are not alone, that's why there are 3 open issues. But someone should finish the different proposition and write a n

[issue16310] zipfile: allow surrogates in filenames

Stefan Holek added the comment: > It's possible to distribute Python packages with non-ASCII filenames. Well, it wasn't until very recently (distribute 0.6.29): https://bitbucket.org/tarek/distribute/issue/303/no-support-for-unicode-manifest-files Unless we are not talking about the same thing,

[issue16310] zipfile: allow surrogates in filenames

STINNER Victor added the comment: > The use-case is building Python distributions containing > non-ASCII filenames. It's possible to distribute Python packages with non-ASCII filenames. > So yes, I have Latin-1 bytes on the filesystem, > even though my locale is UTF-8. You system is not config

[issue16310] zipfile: allow surrogates in filenames

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16310] zipfile: allow surrogates in filenames

Serhiy Storchaka added the comment: Related issues: issue10614, issue10757, issue10972. -- ___ Python tracker ___ ___ Python-bugs-list

[issue16310] zipfile: allow surrogates in filenames

Serhiy Storchaka added the comment: If we allow for surrogates in the names, it will not correct UTF-8. This can breaks other software. We should clear 11th flag bit in this case. -- ___ Python tracker _

[issue16310] zipfile: allow surrogates in filenames

Stefan Holek added the comment: What we are trying to do is make distribute work with non-ASCII filenames, and this is one of the things we ran into. Fact 1: Filenames are bytes, whether you like it or not. Treating them as strings is going to give you more trouble than dragging the bytes alon

[issue16310] zipfile: allow surrogates in filenames

Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16310] zipfile: allow surrogates in filenames

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue16310] zipfile: allow surrogates in filenames

R. David Murray added the comment: I'm guessing that is because (if you read the issue) there are no specified standards for the filenames in tar (other than PAX format). Although I would personally have preferred to need to specify a "yes really use these binary filenames" flag to tar, as we

[issue16310] zipfile: allow surrogates in filenames

Stefan Holek added the comment: A little more context perhaps: The use-case is building Python distributions containing non-ASCII filenames. These seemingly "invalid" filenames can occur in real-life when the files have been created by, say, a 'git clone' operation. So yes, I have Latin-1 byt

[issue16310] zipfile: allow surrogates in filenames

R. David Murray added the comment: The problem you are reporting looks different than the problem addressed in issue 8390. There, the surrogates are being introduced when reading filenames from the archive file. Here, the surrogates presumably arose because the filename on your file system w

[issue16310] zipfile: allow surrogates in filenames

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka type: -> enhancement versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ __

[issue16310] zipfile: allow surrogates in filenames

New submission from Stefan Holek: Please allow for surrogates in the zipfile module like it was done for tarfile in #8390. Currently zipfile breaks when encountering surrogates: Traceback (most recent call last): File "/usr/local/python3.3/lib/python3.3/zipfile.py", line 392, in _encodeFile