[issue16264] test_logging failure on Windows 7 buildbot

Vinay Sajip added the comment: > (note: SocketHandler's implementation looks grotesque. Enough said). Care to be a little more constructive in your criticism? I'm quite open to improving it, if you have any suggestions for doing so. It's a very basic exponential back-off approach - the only in

[issue16264] test_logging failure on Windows 7 buildbot

Antoine Pitrou added the comment: Looks ok now. It's a timing glitch because both SocketHandler's built-in timeout and its default retry delay are one second, so when connect times out once the next retry time is a bit behind time.time(). (note: SocketHandler's implementation looks grotesque.

[issue16264] test_logging failure on Windows 7 buildbot

Roundup Robot added the comment: New changeset 0fb2267897ba by Antoine Pitrou in branch 'default': Try to fix issue #16264 (test_logging failure on some buildbots). http://hg.python.org/cpython/rev/0fb2267897ba -- ___ Python tracker

[issue16264] test_logging failure on Windows 7 buildbot

Giampaolo Rodola' added the comment: Committed http://hg.python.org/cpython/rev/240fa6e93925 in order to have a clearer look on what's going on. Will get back on this later today, after the next bb failure. -- ___ Python tracker

[issue16264] test_logging failure on Windows 7 buildbot

Roundup Robot added the comment: New changeset 240fa6e93925 by Giampaolo Rodola' in branch 'default': test_logging.py: where needed use unittest's assertGreater, assertLesser, assertIs rather than assertTrue (also in order to debug issue 16264) http://hg.python.org/cpython/rev/240fa6e93925

[issue16264] test_logging failure on Windows 7 buildbot

New submission from Antoine Pitrou: Changeset d3c7ebdc71bb produced the following test failure on one of the stable buildbots: == FAIL: test_noserver (test.test_logging.SocketHandlerTest) --