[issue16121] shlex.shlex.error_leader() reports incorrect line number

Changes by Petri Lehtinen : -- nosy: -petri.lehtinen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Changes by Christopher Hoadley : -- nosy: +hoadlck versions: +Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue16121] shlex.shlex.error_leader() reports incorrect line number

R. David Murray added the comment: I think I'll leave it up to whoever works on this whether they want to tackle making posix mode and non-posix mode return the same values or turn this into an enhancement ticket for the proposed wrapped_lineno. Or, if no one is interested, we can just close

[issue16121] shlex.shlex.error_leader() reports incorrect line number

R. David Murray added the comment: Is it necessarily a bug if the behavior is different with posix=True or False? If I understand correctly, non-posix mode is a backward compatibility mode, and really nobody "should" be using non-posix mode any more :) --

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Birk Nilson added the comment: After investigating the issue I have a couple of proposals. Although a bit vague, the documentation of shlex.lineo seems to suggest that it should be incremented immediately on finding a newline character. Changing this to allow wrapped lines within a token witho

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Petri Lehtinen added the comment: > I'm investigating it now and will get back with a revised & > fully tested patch. Sounds good. FWIW, it only broke on 3.x and default branches, and you can probably reproduce it on my own machine, too, by applying the patch and then running test_netrc. This

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Birk Nilson added the comment: Sorry about that. Rookie mistake. I'm investigating it now and will get back with a revised & fully tested patch. -- ___ Python tracker ___ __

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Petri Lehtinen added the comment: Reverted the patch because of the broken netrc tests. This has to be investigated further. -- resolution: fixed -> stage: committed/rejected -> commit review ___ Python tracker _

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Roundup Robot added the comment: New changeset 34f759fa5484 by Petri Lehtinen in branch '2.7': Revert "Issue #16121: Fix line number accounting in shlex" http://hg.python.org/cpython/rev/34f759fa5484 New changeset cda4a9dc415a by Petri Lehtinen in branch '3.2': Revert "Issue #16121: Fix line num

[issue16121] shlex.shlex.error_leader() reports incorrect line number

R. David Murray added the comment: Something in this change seems to have broken netrc: http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.3/builds/520 -- nosy: +r.david.murray status: closed -> open ___ Python tracker

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Petri Lehtinen added the comment: Applied, thanks! -- nosy: +petri.lehtinen resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker _

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Roundup Robot added the comment: New changeset e54ee8d2c16b by Petri Lehtinen in branch '2.7': Issue #16121: Fix line number accounting in shlex http://hg.python.org/cpython/rev/e54ee8d2c16b New changeset f1d19fdb254f by Petri Lehtinen in branch '3.2': Issue #16121: Fix line number accounting in

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Birk Nilson added the comment: The implementation incremented the line number immediately when a newline was detected, even before the token had been processed completely - causing the issue Arfrever posted. This also caused the unexpected behavior of a tokens line number including the amount

[issue16121] shlex.shlex.error_leader() reports incorrect line number

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> needs patch type: -> behavior ___ Python tracker ___ ___ Python-bugs-list

[issue16121] shlex.shlex.error_leader() reports incorrect line number

New submission from Arfrever Frehtes Taifersar Arahesis: shlex.shlex.error_leader() reports incorrect line number with posix=True or when last token is not quoted. This bug occurs in all versions of Python. The attached script shows this bug: $ ./shlex_test.py ### text1 posix=False ('var1', '"N