[issue15795] Zipfile.extractall does not preserve file permissions

Éric Araujo added the comment: On second thought, maybe no fix should be backported. Changing behaviour silently might break things, changing with a new option puts the change in a grey fix/enhancement area, so maybe better to let current versions as they are, with the bug/limitation noted in

[issue15795] Zipfile.extractall does not preserve file permissions

Sam Ezeh added the comment: I don't know what the best course of action would be but if preserving permissions needs to be back-ported, could the default permission preservation flag in 3.11+ be the one to preserve safe permissions and then make it so that the previous versions (<3.11, witho

[issue15795] Zipfile.extractall does not preserve file permissions

Change by Éric Araujo : -- versions: +Python 3.11 -Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15795] Zipfile.extractall does not preserve file permissions

Éric Araujo added the comment: The new PR uses new constants*, so could not be backported as is (see my previous message). (*side question: should the constants use an enum?) -- ___ Python tracker

[issue15795] Zipfile.extractall does not preserve file permissions

Change by Sam Ezeh : -- pull_requests: +30350 pull_request: https://github.com/python/cpython/pull/32289 ___ Python tracker ___ ___

[issue15795] Zipfile.extractall does not preserve file permissions

Change by Sam Ezeh : -- nosy: +sam_ezeh ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue15795] Zipfile.extractall does not preserve file permissions

Change by Selim Belhaouane : -- nosy: +selimb ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue15795] Zipfile.extractall does not preserve file permissions

Joannah Nanjekye added the comment: I left a review on the PR requesting for some tests, if it makes sense. -- nosy: +nanjekyejoannah ___ Python tracker ___ __

[issue15795] Zipfile.extractall does not preserve file permissions

Éric Araujo added the comment: The pull request needs unit tests added to validate the changes. Note that the patch attached here was a new feature, adding constants and parameters to control the behaviour, but the PR simply checks and applies permissions bits stored in the entry. That seems

[issue15795] Zipfile.extractall does not preserve file permissions

Change by William Woodruff : -- nosy: +yossarian ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue15795] Zipfile.extractall does not preserve file permissions

Nikolay added the comment: Is there any chance that the pull request will be accepted? I'm a bit tired of using workaround every time I need unzip something on linux. -- nosy: +kulakov-n ___ Python tracker

[issue15795] Zipfile.extractall does not preserve file permissions

Change by Roundup Robot : -- pull_requests: +17223 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/17790 ___ Python tracker ___

[issue15795] Zipfile.extractall does not preserve file permissions

Change by ABR : -- nosy: -arobert ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mai

[issue15795] Zipfile.extractall does not preserve file permissions

Étienne Dupuis added the comment: A workaround is provided here: https://stackoverflow.com/questions/39296101/python-zipfile-removes-execute-permissions-from-binaries -- nosy: +Étienne Dupuis ___ Python tracker

[issue15795] Zipfile.extractall does not preserve file permissions

Karen Tracey added the comment: Note the zipfile being processed may have been created on a non-Unix system, and the external_attr value can't be usefully interpreted as permission bits when the value at _CD_CREATE_SYSTEM (https://hg.python.org/cpython/file/default/Lib/zipfile.py#l107) in the

[issue15795] Zipfile.extractall does not preserve file permissions

Mark Mikofski added the comment: same problem in 2.7.5 on Oracle Linux 7.2 -- nosy: +bwanamarko ___ Python tracker ___ ___ Python-bugs

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by R. David Murray : -- stage: commit review -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15795] Zipfile.extractall does not preserve file permissions

Alexey Boriskin added the comment: I'm working on updating the patch to unify tarfile and zipfile interfaces and to restore owner/timestamp for zipfile -- ___ Python tracker ___

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by Alexander Belopolsky : -- nosy: +belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by R. David Murray : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue15795] Zipfile.extractall does not preserve file permissions

ABR added the comment: I hope this can be finally gotten in for 3.5, even if it's not the perfect solution. I hit this issue and needed to call out to a subprocess as a work-around, but that's far less reliable. -- nosy: +arobert ___ Python tracker

[issue15795] Zipfile.extractall does not preserve file permissions

Serhiy Storchaka added the comment: The TarFile.extract() method has the set_attrs parameter which controls similar behavior but is less flexible. It would be good to unify zipfile and tarfile abilities. set_attrs also controls setting file owner and time. When we restore unsafe uid/gid/sticky

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by William Ehlhardt : -- nosy: +Orborde ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by Claudiu Popa : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue15795] Zipfile.extractall does not preserve file permissions

Glenn Jones added the comment: Patch with docs and tests fixed -- Added file: http://bugs.python.org/file34893/issue15795_test_and_doc_fixes.patch ___ Python tracker ___

[issue15795] Zipfile.extractall does not preserve file permissions

Claudiu.Popa added the comment: Hello. I added a couple of comments to your latest patch. -- nosy: +Claudiu.Popa ___ Python tracker ___ __

[issue15795] Zipfile.extractall does not preserve file permissions

Glenn Jones added the comment: Patch cleaned up based on previous comments. -- Added file: http://bugs.python.org/file34873/issue15795_cleaned.patch ___ Python tracker ___ __

[issue15795] Zipfile.extractall does not preserve file permissions

R. David Murray added the comment: Thanks. The patch contains a number of lines that are not wrapped to <80, which is one of our requirements. It would be great to get that fixed. (In the documentation, you can use \ to wrap the prototype line.) There is non-ascii in one place in the docume

[issue15795] Zipfile.extractall does not preserve file permissions

Glenn Jones added the comment: Here is an updated patch that applies cleanly to head. Tests pass against head of repo. -- nosy: +Glenn.Jones Added file: http://bugs.python.org/file34852/issue15795_updated.patch ___ Python tracker

[issue15795] Zipfile.extractall does not preserve file permissions

Ronald Oussoren added the comment: On first glance the patch looks good. I haven't tested it with the current trunk though. -- nosy: +ronaldoussoren ___ Python tracker ___ _

[issue15795] Zipfile.extractall does not preserve file permissions

anatoly techtonik added the comment: There should be an easy way to restore file attributes. -- ___ Python tracker ___ ___ Python-bugs

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by anatoly techtonik : -- nosy: +techtonik ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by Cédric de Saint Martin : -- nosy: +desaintmartin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue15795] Zipfile.extractall does not preserve file permissions

R. David Murray added the comment: OK, so this is an enhancement to specifically allow preservation of "unsafe" permissions? Adding the nosy list from issue 3394. -- nosy: +cbrannon, pitrou, swarren type: behavior -> enhancement versions: -Python 2.7 _

[issue15795] Zipfile.extractall does not preserve file permissions

Aaron Train added the comment: Thanks for the patch. Is this going to be resolved soon? -- nosy: +Aaron.Train ___ Python tracker ___ _

[issue15795] Zipfile.extractall does not preserve file permissions

Alexey Boriskin added the comment: I'm attaching a patch, which solves the issue. Patch intoduces new argument "preserve_permissions" for extract and extractall methods. That argument may accept one of the three values: do not preserve permissions, preserve a safe subset of them or preserve al

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by R. David Murray : -- hgrepos: -147 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by Alexey Boriskin : -- hgrepos: +147 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue15795] Zipfile.extractall does not preserve file permissions

R. David Murray added the comment: Does this have any relationship to issue 3394? From the discussion on that issue it sounds like zipfile is doing things with external_attributes if it is set. But I don't know much about zipfile internals. -- nosy: +r.david.murray _

[issue15795] Zipfile.extractall does not preserve file permissions

New submission from Alexey Boriskin: Zipfile._extract_member does not preserve file permissions while extracting it. As may be seen at link[1], raw open() is used and no os.chmod() applied after that, therefore any permission data stored in zipfile is dropped and file is created with default p