[issue15794] test_importlib: test_locks failure

2012-08-28 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ P

[issue15794] test_importlib: test_locks failure

2012-08-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 454dceb5fd56 by Antoine Pitrou in branch 'default': Issue #15794: Relax a test case due to the deadlock detection's conservativeness. http://hg.python.org/cpython/rev/454dceb5fd56 -- nosy: +python-dev __

[issue15794] test_importlib: test_locks failure

2012-08-28 Thread Stefan Krah
Stefan Krah added the comment: The patch works fine here (as expected). -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue15794] test_importlib: test_locks failure

2012-08-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: After a bit of investigation, it turns out the test is probably too strict. The deadlock avoidance logic in importlib._bootstrap is indeed conservative: if you take a look at _ModuleLock.acquire(), _blocking_on[tid] is set even while other threads may run, beca

[issue15794] test_importlib: test_locks failure

2012-08-27 Thread Stefan Krah
Stefan Krah added the comment: Also reproduced on Ubuntu Lucid/Core 2 Duo with a very low switch interval and -j4. It takes more repetitions than on the i7: $ ./python -m test -uall -F -j4 test_importlib [...] [224] test_importlib [225] test_importlib [226/1] test_importlib test test_importlib

[issue15794] test_importlib: test_locks failure

2012-08-27 Thread Stefan Krah
New submission from Stefan Krah: On the obstinate i7 machine (see #15781), test_importlib fails sporadically (after 10 repetitions or so). $ ./python -m test -uall -F test_importlib [ 1] test_importlib