[issue15759] "make suspicious" doesn't display instructions in case of failure

Ezio Melotti added the comment: Thanks for fixing this! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue15759] "make suspicious" doesn't display instructions in case of failure

Changes by Serhiy Storchaka : -- assignee: docs@python -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue15759] "make suspicious" doesn't display instructions in case of failure

Roundup Robot added the comment: New changeset 10b83036c723 by Serhiy Storchaka in branch '3.4': Issue #15759: "make suspicious", "make linkcheck" and "make doctest" in Doc/ http://hg.python.org/cpython/rev/10b83036c723 New changeset c755a3b58fa6 by Serhiy Storchaka in branch 'default': Issue #1

[issue15759] "make suspicious" doesn't display instructions in case of failure

Serhiy Storchaka added the comment: Oh, I forgot about this patch. Here is more correct patch. It now works with non-default make command and "make suspicious" now returns success return code if no suspicious markups were found. Made similar fix for the linkcheck and doctest target. -

[issue15759] "make suspicious" doesn't display instructions in case of failure

Ezio Melotti added the comment: Serhiy, your patch LGTM. Can you apply a similar fix for the linkcheck and doctest target and commit it? FWIW the patch produces a slightly different output (in addition to showing the missing message), but I don't think it's a problem: Without patch: ... bui

[issue15759] "make suspicious" doesn't display instructions in case of failure

Larry Hastings added the comment: Can we use unicode characters? I'd like little ships, or U+1F4A9. -- ___ Python tracker ___ ___ Pyt

[issue15759] "make suspicious" doesn't display instructions in case of failure

Serhiy Storchaka added the comment: It was not such good. Here is better patch. -- Added file: http://bugs.python.org/file33727/make_suspicious.patch ___ Python tracker ___ _

[issue15759] "make suspicious" doesn't display instructions in case of failure

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file33726/make_suspicious.patch ___ Python tracker ___ ___ Python-bugs-list

[issue15759] "make suspicious" doesn't display instructions in case of failure

Georg Brandl added the comment: Looks good. Maybe Larry will want his line of stars though :) -- ___ Python tracker ___ ___ Python-bug

[issue15759] "make suspicious" doesn't display instructions in case of failure

Serhiy Storchaka added the comment: Try this patch. -- nosy: +serhiy.storchaka Added file: http://bugs.python.org/file33726/make_suspicious.patch ___ Python tracker ___ _

[issue15759] "make suspicious" doesn't display instructions in case of failure

Larry Hastings added the comment: Since Ezio asked me, I guess I wasn't clear: This message should be displayed at the bottom, after the errors, and only when there are alleged suspicious documentation activities. -- ___ Python tracker

[issue15759] "make suspicious" doesn't display instructions in case of failure

Larry Hastings added the comment: I nominate this text: ** To make these errors go away, merge the contents of "build/suspicious/suspicious.csv" to "tools/sphinxext/susp-ignored.csv". ***

[issue15759] "make suspicious" doesn't display instructions in case of failure

Changes by Ezio Melotti : -- keywords: +easy stage: commit review -> patch review versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___

[issue15759] "make suspicious" doesn't display instructions in case of failure

Georg Brandl added the comment: The error exit code should be preserved though. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue15759] "make suspicious" doesn't display instructions in case of failure

Ezio Melotti added the comment: Apparently a '-' at the beginning of the command means "run this thing and if it fails ignore the failure and keep going". I tried to add an if/else in the build target to use the '-' with the selected builder was "suspicious" but I couldn't make it work, so I

[issue15759] "make suspicious" doesn't display instructions in case of failure

New submission from Ezio Melotti: I was running "make suspicious" in Doc/ and this was the output after finding 3 suspicious markups: writing output... [ 52%] library/inspect WARNING: [library/inspect:437] ":int" found in ">>> def foo(a, *, b:int, **kwargs):" WARNING: [library/inspect:437]