[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-12-14 Thread Jeff Knupp
Changes by Jeff Knupp : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9b28dff66ac3 by Senthil Kumaran in branch 'default': Fix Issue 15743 - improve urllib tests by removing deprecated method usages. Patch by Jeff Knupp. http://hg.python.org/cpython/rev/9b28dff66ac3 -- nosy: +python-dev _

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Jeff Knupp
Jeff Knupp added the comment: Yes, that was part of the original patch which was incorrectly uploaded. The current patch (2) should be correct wrt get_method. -- ___ Python tracker

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Senthil Kumaran
Senthil Kumaran added the comment: One change. get_method has only been changed not deprecated. Those test cases should not change and moreover the current change to assert against .method results in a failure too. get_method would return "GET" when .method is None or empty. --

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Jeff Knupp
Jeff Knupp added the comment: Senthil, sorry, missed your comment and hadn't realized anyone had seen the patch yet. I replaced it with an updated version (had missed a few places deprecated functions were used). Could you review the new patch instead? -- _

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Jeff Knupp
Jeff Knupp added the comment: Updated with correct patch file. -- Added file: http://bugs.python.org/file26936/test_urllib.patch.2 ___ Python tracker ___

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Jeff Knupp
Changes by Jeff Knupp : Removed file: http://bugs.python.org/file26935/test_urllib.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch looks good to me. Thanks Jeff. -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Jeff Knupp
Jeff Knupp added the comment: Attaching patch. -- keywords: +patch Added file: http://bugs.python.org/file26935/test_urllib.patch ___ Python tracker ___ _

[issue15743] test_urllib2/test_urllib use deprecated urllib.Request methods

2012-08-20 Thread Jeff Knupp
New submission from Jeff Knupp: urllib was updated to deprecate a number of Request methods for 3.3. The test_urllib2 and test_urllib tests still use some of the deprecated methods. -- components: Tests messages: 168692 nosy: Jeff.Knupp priority: normal severity: normal status: open tit