[issue1574217] isinstance swallows exceptions

R. David Murray added the comment: Upon reflection I think the risk of breaking apparently working programs is higher than the benefit to be obtained from backporting this. -- ___ Python tracker ___

[issue1574217] isinstance swallows exceptions

Changes by R. David Murray : -- versions: -Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue1574217] isinstance swallows exceptions

R. David Murray added the comment: I've committed this (with the whitespace fix) in r86577. I've made myself a note to backport it when the maint branches unfreeze. -- assignee: nnorwitz -> nosy: +r.david.murray resolution: -> fixed stage: patch review -> committed/rejected status:

[issue1574217] isinstance swallows exceptions

Graham Poulter added the comment: issue1574217.diff still applies against py3k as revision 86545 (offset -8 lines) patching file Objects/abstract.c Hunk #1 succeeded at 2500 (offset -8 lines). Hunk #2 succeeded at 2523 (offset -8 lines). And tests pass (./python ./Lib/test/test_isinstance.py

[issue1574217] isinstance swallows exceptions

Changes by Alexander Belopolsky : Added file: http://bugs.python.org/file18002/issue1574217.diff ___ Python tracker ___ ___ Python-bugs-list

[issue1574217] isinstance swallows exceptions

Alexander Belopolsky added the comment: I have verified that the issue is present in py3k. The unit test portion of the patch applies cleanly in py3k an the added tests fail. The code portion applies with patch -l and fixes the issue. I'll upload a patch with fixed white space. --

[issue1574217] isinstance swallows exceptions

Alexander Belopolsky added the comment: This looks like a borderline case between a bug and a feature request. If this is deemed to be a feature, it is not appropriate for 2.x or 3.1. In any case, I think the first step should be to consider this for py3k branch. -- ___

[issue1574217] isinstance swallows exceptions

Tres Seaver added the comment: This bug exists in Python 2.6 and 3.1, which are still being maintained, AFAIK. -- versions: +Python 2.6, Python 3.1 ___ Python tracker ___

[issue1574217] isinstance swallows exceptions

Alexander Belopolsky added the comment: I don't see it being applied. Tres Seaver above reports that issue1574217_dont_mask_errors.txt applies cleanly to 2.6 branch, which means that it has not been applied yet. Someone needs to check if the patch is current for 2.7 and py3k branches to mov

[issue1574217] isinstance swallows exceptions

Mark Lawrence added the comment: Can we get this closed as the patch is in 2.6 already, just needs to be applied to the later versions. Or have I missed something? -- nosy: +BreamoreBoy versions: +Python 3.2 ___ Python tracker

[issue1574217] isinstance swallows exceptions

Changes by Tres Seaver : -- versions: +Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue1574217] isinstance swallows exceptions

Tres Seaver added the comment: I can confirm that the patch applies cleanly to the 2.6 branch, that the new test fails before rebuilding, and that the test passes afterwards: $ hg summary parent: 41597:295c02a21979 tip [svn r80597] Merged revisions 80596 via svnmerge from branch: release2

[issue1574217] isinstance swallows exceptions

Changes by Daniel Diniz : -- keywords: +patch stage: -> patch review type: -> behavior versions: +Python 2.7, Python 3.1 -Python 2.4, Python 2.5, Python 2.6 ___ Python tracker __

[issue1574217] isinstance swallows exceptions

Neal Norwitz <[EMAIL PROTECTED]> added the comment: > I'd like to clarify the approach to fixing these types of problems. > ... > However, I like constricting it to AttributeError only as that would > make it much less confusing. This might be something to bring up on > python-dev. I suspect tha

[issue1574217] isinstance swallows exceptions

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I'd like to clarify the approach to fixing these types of problems. I fixed a issue (#2196) like this by only propagating exceptions that didn't descend from Exception because of this sentence in the hasattr docs: This is implemented by ca

[issue1574217] isinstance swallows exceptions

Georg Brandl <[EMAIL PROTECTED]> added the comment: There are more locations in abstract.c where exceptions are unconditionally masked after a GetAttr operation: * line 1630, 1717 in PyNumber_{Long,Int} when looking for .__trunc__ * line 2932, in PyObject_IsInstance -- nosy: +benjamin.p

[issue1574217] isinstance swallows exceptions

Ralf Schmitt added the comment: The return value should be -1 in case of errors. There's also a second code path swallowing all errors. I've converted brian's test.py to a unit test testing both code paths and added an updated patch for this one. This patch is against trunk. All tests in Lib/test

[issue1574217] isinstance swallows exceptions

Neal Norwitz added the comment: Yeah, this seems like a bug and the patch seems correct. The patch also needs a test and add a space between if (. _ Tracker <[EMAIL PROTECTED]> _ __

[issue1574217] isinstance swallows exceptions

Changes by Brian Harring : -- versions: +Python 2.5 _ Tracker <[EMAIL PROTECTED]> _