[issue1569291] Speed-up in array_repeat()

Georg Brandl added the comment: I changed the patch to look more like unicode_repeat (which addresses Alex' point #2) and committed in r87022. -- resolution: -> accepted status: open -> closed ___ Python tracker

[issue1569291] Speed-up in array_repeat()

Changes by Daniel Stutzbach : -- nosy: +stutzbach ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue1569291] Speed-up in array_repeat()

Georg Brandl added the comment: Uh, this slipped under my radar. Let's see if I get the chance to look at it at the core sprint next week. -- ___ Python tracker ___

[issue1569291] Speed-up in array_repeat()

Mark Lawrence added the comment: There are lots of positive comments on this issue, please can core developers take a bit of time to have a look and say yes or no. -- nosy: +BreamoreBoy versions: +Python 2.7, Python 3.2 -Python 2.6 ___ Python tracke

[issue1569291] Speed-up in array_repeat()

Changes by Daniel Diniz : -- stage: -> patch review versions: +Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue1569291] Speed-up in array_repeat()

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: Georg, do you want to take it from here. -- assignee: rhettinger -> georg.brandl nosy: +georg.brandl ___ Python tracker <[EMAIL PROTECTED]>

[issue1569291] Speed-up in array_repeat()

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: I forgot to mention that I added a unit test to cover the special case of repeating a single-byte array. _ Tracker <[EMAIL PROTECTED]> ___

[issue1569291] Speed-up in array_repeat()

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: Attached patch (issue1569291.diff) reimplements the optimization by following Objects/stringobject.c logic as Raymond suggested. I see two remaining issues which in my view should be addressed separately: 1. There is no check for overf

[issue1569291] Speed-up in array_repeat()

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: Looking at stringobject.c:1034: i = 0; if (i < size) { Py_MEMCPY(op->ob_sval, a->ob_sval, Py_SIZE(a)); i = Py_SIZE(a); } while (i < size) { j = (i <= size-i) ? i : size-i; Py_MEMCPY(op->

[issue1569291] Speed-up in array_repeat()

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: This one is easy if someone wants to take a crack at it. -- keywords: +easy -patch _ Tracker <[EMAIL PROTECTED]> _ _