[issue15676] mmap: add empty file check prior to offset check

Jesús Cea Avión added the comment: Thanks for the heads-up, Stefan. -- assignee: -> jcea resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue15676] mmap: add empty file check prior to offset check

Roundup Robot added the comment: New changeset 39efccf7a167 by Jesus Cea in branch '2.7': #15676: mmap: add empty file check prior to offset check <- Previous patch was incomplete (fix 2) http://hg.python.org/cpython/rev/39efccf7a167 New changeset 56a2e862561c by Jesus Cea in branch '3.2': #156

[issue15676] mmap: add empty file check prior to offset check

Stefan Krah added the comment: I think Py_DECREF(m_obj) is missing (at least in 3.3, I didn't look at the other versions). -- ___ Python tracker ___ _

[issue15676] mmap: add empty file check prior to offset check

Roundup Robot added the comment: New changeset 88a88c32661e by Jesus Cea in branch '3.2': #15676: mmap: add empty file check prior to offset check <- Previous patch was incomplete http://hg.python.org/cpython/rev/88a88c32661e New changeset 0ac94ae29abe by Jesus Cea in branch 'default': #15676:

[issue15676] mmap: add empty file check prior to offset check

Roundup Robot added the comment: New changeset 25d477647a2d by Jesus Cea in branch '2.7': #15676: mmap: add empty file check prior to offset check <- Previous patch was incomplete http://hg.python.org/cpython/rev/25d477647a2d -- ___ Python tracker <

[issue15676] mmap: add empty file check prior to offset check

Stefan Krah added the comment: This gets rid of the permission error: diff -r f962ec8e47a1 Lib/test/test_mmap.py --- a/Lib/test/test_mmap.py Mon Sep 10 01:23:05 2012 +0200 +++ b/Lib/

[issue15676] mmap: add empty file check prior to offset check

Stefan Krah added the comment: For some reason all Windows buildbots are failing since f962ec8e47a1: == ERROR: test_entire_file (test.test_mmap.MmapTests) -- Tr

[issue15676] mmap: add empty file check prior to offset check

Roundup Robot added the comment: New changeset 9ed2e8307e60 by Jesus Cea in branch '2.7': #15676: Proper attribution in Misc/ACKS http://hg.python.org/cpython/rev/9ed2e8307e60 New changeset 4f21f7532038 by Jesus Cea in branch '3.2': #15676: Proper attribution in Misc/ACKS http://hg.python.org/cp

[issue15676] mmap: add empty file check prior to offset check

Charles-François Natali added the comment: You forgot to add an entry in Misc/ACKS. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue15676] mmap: add empty file check prior to offset check

Roundup Robot added the comment: New changeset d85f80b31b54 by Jesus Cea in branch '3.2': Closes #15676: mmap: add empty file check prior to offset check http://hg.python.org/cpython/rev/d85f80b31b54 New changeset f962ec8e47a1 by Jesus Cea in branch 'default': Closes #15676: mmap: add empty file

[issue15676] mmap: add empty file check prior to offset check

Jesús Cea Avión added the comment: Having separate patches is useful if the patch can not be applied cleanly to different python branches. This is specially true with 2.7/3.x. Checking the fix and committing it to 2.7, 3.2 and 3.3 (probably available in 3.3.1, not 3.3.0, already in release can

[issue15676] mmap: add empty file check prior to offset check

Steven Willis added the comment: Sorry, I thought that's what jcea was asking for. Here's an updated patch for the default branch in mercurial that uses assertRaisesRegex in the test. -- Added file: http://bugs.python.org/file27156/issue15676-default.patch _

[issue15676] mmap: add empty file check prior to offset check

Charles-François Natali added the comment: Thanks for the patches. Note that you don't have to provide a patch for each branch, it's usually the committer's job. The patch looks good, but the test could be rewritten with assertRaisesRegex(): http://docs.python.org/dev/library/unittest.html#unit

[issue15676] mmap: add empty file check prior to offset check

Changes by Steven Willis : -- versions: +Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue15676] mmap: add empty file check prior to offset check

Steven Willis added the comment: Here's a branch against the default branch in mercurial. I couldn't find a branch for 3.3 or 3.4. -- Added file: http://bugs.python.org/file27155/issue15676-default.patch ___ Python tracker

[issue15676] mmap: add empty file check prior to offset check

Steven Willis added the comment: Here's a patch for 3.2 -- Added file: http://bugs.python.org/file27154/issue15676-3.2.patch ___ Python tracker ___ __

[issue15676] mmap: add empty file check prior to offset check

Steven Willis added the comment: Here's a patch for 3.1 -- Added file: http://bugs.python.org/file27153/issue15676-3.1.patch ___ Python tracker ___ __

[issue15676] mmap: add empty file check prior to offset check

Steven Willis added the comment: Here's a patch for 2.7. I don't know if it cleanly applies to the rest. -- keywords: +patch Added file: http://bugs.python.org/file27140/issue15676.patch ___ Python tracker

[issue15676] mmap: add empty file check prior to offset check

Changes by Berker Peksag : -- versions: -Python 3.1, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15676] mmap: add empty file check prior to offset check

Jesús Cea Avión added the comment: I do agree. Solaris also returns an error if len=0. Could you please, provide patches for 2.7, 3.2 and 3.3? -- ___ Python tracker ___

[issue15676] mmap: add empty file check prior to offset check

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15676] mmap: add empty file check prior to offset check

New submission from Steven Willis: There are a number of issues dealing with the offset and length checks in offset, such as issue12556. I'm running into this issue as well, but with a normal file that happens to be empty. I'm trying to access it with: mmap.mmap(f.fileno(), length=0, access=m