[issue15519] finish exposing WindowsRegistryImporter in importlib

Changes by Nick Coghlan : -- stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Python-bugs-l

[issue15519] finish exposing WindowsRegistryImporter in importlib

Nick Coghlan added the comment: This didn't close automatically (I assume the open dependency upset matters, since it also prevented me from closing it manually the first time). Applied to trunk in http://hg.python.org/cpython/rev/a1ac1e13c5a0 (including the rename from #15502) -- dep

[issue15519] finish exposing WindowsRegistryImporter in importlib

Nick Coghlan added the comment: We'll also want to add this to the inheritance tests in test_importlib.test_abc -- ___ Python tracker ___

[issue15519] finish exposing WindowsRegistryImporter in importlib

Brett Cannon added the comment: It should be exposed (i.e. if SourcelessFileLoader is documented and exposed then so should WindowsRegistryFinder). -- ___ Python tracker ___ ___

[issue15519] finish exposing WindowsRegistryImporter in importlib

Eric Snow added the comment: I guess the real question here is if anyone has problems with adding WindowsRegistryFinder to importlib.machinery (and to the importlib docs). If it should stay private than I'd like to throw a _ on the name of the class. The change to importlib.abc would likely

[issue15519] finish exposing WindowsRegistryImporter in importlib

Eric Snow added the comment: Also, WindowsRegistryImporter is misnamed. It should be WindowsRegistryFinder (see issue15502). Depending on the patch there, I'll update the one here. -- dependencies: +Meta path finders and path entry finders are different, but share an ABC ___

[issue15519] finish exposing WindowsRegistryImporter in importlib

Antoine Pitrou added the comment: > The importers can both find and load modules (e.g. BuiltinImporter > defines both find_module() and load_module()), while the finders only > find modules (e.g. only define find_module()). Ah, fair enough. I thought loader objects were always distinct from find

[issue15519] finish exposing WindowsRegistryImporter in importlib

Brett Cannon added the comment: The importers can both find and load modules (e.g. BuiltinImporter defines both find_module() and load_module()), while the finders only find modules (e.g. only define find_module()). It's defined in the glossary, so maybe more links to that would help. ---

[issue15519] finish exposing WindowsRegistryImporter in importlib

Antoine Pitrou added the comment: I'm not sure why some finders are named "Finder" and others "Importer". It makes things confusing. -- nosy: +pitrou ___ Python tracker ___

[issue15519] finish exposing WindowsRegistryImporter in importlib

Changes by Nick Coghlan : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue15519] finish exposing WindowsRegistryImporter in importlib

Changes by Eric Snow : Added file: http://bugs.python.org/file26637/issue15519_expose_importer.diff ___ Python tracker ___ ___ Python-bugs-lis

[issue15519] finish exposing WindowsRegistryImporter in importlib

Changes by Eric Snow : Removed file: http://bugs.python.org/file26636/issue15519_expose_importer.diff ___ Python tracker ___ ___ Python-bugs-l

[issue15519] finish exposing WindowsRegistryImporter in importlib

Changes by Eric Snow : -- keywords: +patch Added file: http://bugs.python.org/file26636/issue15519_expose_importer.diff ___ Python tracker ___ ___

[issue15519] finish exposing WindowsRegistryImporter in importlib

New submission from Eric Snow: 1. add to importlib.machinery 2. register on importlib.abc.Finder patch in a moment. -- components: Interpreter Core keywords: needs review messages: 167074 nosy: brett.cannon, eric.snow, loewis priority: normal severity: normal stage: patch review status: