[issue15507] test_subprocess assumes SIGINT is not being ignored.

2013-08-29 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed type: -> behavior ___ Python tracker ___

[issue15507] test_subprocess assumes SIGINT is not being ignored.

2013-08-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9810844126e1 by Gregory P. Smith in branch '3.3': Fixes issue #15507: test_subprocess's test_send_signal could fail if the test http://hg.python.org/cpython/rev/9810844126e1 New changeset 6aa7ca40b100 by Gregory P. Smith in branch 'default': Fixes I

[issue15507] test_subprocess assumes SIGINT is not being ignored.

2012-07-31 Thread Thomas Wouters
Thomas Wouters added the comment: No, using preexec_fn leaves all kinds of races when mixing threads and processes (which is a bad idea, but people still sometimes do.) And no, restore_signals doesn't fix this; restore_signals only resets the signals the *Python interpreter itself* ignored: SI

[issue15507] test_subprocess assumes SIGINT is not being ignored.

2012-07-31 Thread Richard Oudkerk
Richard Oudkerk added the comment: > Couldn't the preexec_fn argument of Popen be used instead? Actually, since Python 3.2 you can just use "restore_signals=True". -- ___ Python tracker ___

[issue15507] test_subprocess assumes SIGINT is not being ignored.

2012-07-31 Thread Richard Oudkerk
Richard Oudkerk added the comment: Couldn't the preexec_fn argument of Popen be used instead? -- nosy: +sbt ___ Python tracker ___ ___

[issue15507] test_subprocess assumes SIGINT is not being ignored.

2012-07-30 Thread Thomas Wouters
Thomas Wouters added the comment: Patch attached to (briefly) set signal.SIGINT to the default in the test. It may make sense to add a feature to subprocess.Popen to ignore/unignore signals (it should only need to support SIG_DFL and SIG_IGN, not other signal handlers, considering there'll be

[issue15507] test_subprocess assumes SIGINT is not being ignored.

2012-07-30 Thread Thomas Wouters
New submission from Thomas Wouters: test_subprocess's test_send_signal assumes SIGINT is not being ignored, by spawning a new process and expecting it to have the default SIGINT handler . SIGINT can be set to SIG_IGN if the process running the test inherited it from the parent process. --