[issue15386] Still getting two copies of importlib._bootstrap

STINNER Victor added the comment: New changeset 8b7db5a1114e2113a756bdf8877fbe366055c69a by Victor Stinner in branch 'master': bpo-37473: Don't import importlib ASAP in tests (GH-14661) https://github.com/python/cpython/commit/8b7db5a1114e2113a756bdf8877fbe366055c69a -- nosy: +vstin

[issue15386] Still getting two copies of importlib._bootstrap

Change by STINNER Victor : -- pull_requests: +14469 pull_request: https://github.com/python/cpython/pull/14661 ___ Python tracker ___ __

[issue15386] Still getting two copies of importlib._bootstrap

Nick Coghlan added the comment: That was a *lot* harder than I expected to create a test for - I had to import importlib right at the start of regrtest, as well as tweak the import order in runpy, and doing so actually caused test_import to *crash* completely without the bug fixed. The trick

[issue15386] Still getting two copies of importlib._bootstrap

Roundup Robot added the comment: New changeset 4431dc4bb770 by Nick Coghlan in branch 'default': Close #15386: There was a loophole that meant importlib.machinery and imp would sometimes reference an uninitialised copy of importlib._bootstrap http://hg.python.org/cpython/rev/4431dc4bb770 -

[issue15386] Still getting two copies of importlib._bootstrap

Changes by Meador Inge : -- nosy: +meador.inge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15386] Still getting two copies of importlib._bootstrap

Changes by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue15386] Still getting two copies of importlib._bootstrap

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15386] Still getting two copies of importlib._bootstrap

Brett Cannon added the comment: Nice catch! Obviously that needs a big comment to avoid that problem in the future. -- versions: +Python 3.3 ___ Python tracker ___

[issue15386] Still getting two copies of importlib._bootstrap

Nick Coghlan added the comment: Checking with importlib.abc and importlib.util (which turned out not to have the problem) put me on the right path: the problem is the import of "imp" in importlib.__init__ What appears to be happening is that the interpreter sees the partially initialised imp

[issue15386] Still getting two copies of importlib._bootstrap

Nick Coghlan added the comment: Yup. A simpler demonstration: Python 3.3.0b1 (default:8bf691d0b004+, Jul 15 2012, 23:20:06) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from importlib import _bootstrap, machinery >>>

[issue15386] Still getting two copies of importlib._bootstrap

Brett Cannon added the comment: I would have said that it wasn't because it was just the class type not picking up on the __name__ re-assignment, but that global name failure states otherwise. -- nosy: +brett.cannon ___ Python tracker

[issue15386] Still getting two copies of importlib._bootstrap

Changes by Nick Coghlan : -- title: Still getting two copies of importlib._boostrap -> Still getting two copies of importlib._bootstrap ___ Python tracker ___ __