[issue15280] Don't use builtins as variable names in urllib.request

R. David Murray added the comment: I agree. The one change that has a non-style motivation (type) is one that should not be made for backward compatibility reasons. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed _

[issue15280] Don't use builtins as variable names in urllib.request

Martin Panter added the comment: The name changes to the function parameters should be avoided without a good reason. I would recommend rejecting all of the changes in this patch. They are basically changing one person’s coding style to another person’s style. I happen to prefer list() and ma

[issue15280] Don't use builtins as variable names in urllib.request

Éric Araujo added the comment: Well, here I don’t see the benefit in avoiding the use of “file”, given that the builtin of the same name is not needed thanks to the open function (contrary to id, type, str, string and others). If you think our (unwritten?) policy of not doing cleanup-only comm

[issue15280] Don't use builtins as variable names in urllib.request

Michael Foord added the comment: Code cleanups for their own sake sound like a good thing, *iff* the cleanup is worthwhile (for example it makes debugging easier). i.e. the cleanup isn't "gratuitous" but worthwhile. This seems to be the case here and the rejected patch in issue #15137 had oth

[issue15280] Don't use builtins as variable names in urllib.request

Éric Araujo added the comment: > Not being able to use 'type' directly is rather annoying, so after figuring > that bug out I set > some time aside to make it easier for the next person. If you make a patch for #15002 then by all means rename “type” to “filetype” so that you can use the type f

[issue15280] Don't use builtins as variable names in urllib.request

Brian Brazil added the comment: This patch is a result of frustration encountered when debugging #15002. Not being able to use 'type' directly is rather annoying, so after figuring that bug out I set some time aside to make it easier for the next person. This could be considered a bug that urll

[issue15280] Don't use builtins as variable names in urllib.request

Éric Araujo added the comment: We don’t do code cleanups for their own sake, but rather as part of a bug fix or feature addition. Please see #15137 for a longer explanation. -- nosy: +eric.araujo, r.david.murray, terry.reedy ___ Python tracker

[issue15280] Don't use builtins as variable names in urllib.request

Changes by Terry J. Reedy : -- nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue15280] Don't use builtins as variable names in urllib.request

New submission from Brian Brazil : See attached patch, there's still self.type in places. I also converted one map to a list comprehension. -- components: Library (Lib) files: urllib-request-cleanup-builtin-names.patch keywords: patch messages: 164874 nosy: bbrazil priority: normal seve