[issue15239] Abandoned Tools/unicode/mkstringprep.py

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Roundup Robot added the comment: New changeset 8f95d77443da by Serhiy Storchaka in branch '3.3': Issue #15239: Make mkstringprep.py work again on Python 3. http://hg.python.org/cpython/rev/8f95d77443da New changeset 4abe61a412be by Serhiy Storchaka in branch 'default': Issue #15239: Make mkstrin

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Serhiy Storchaka added the comment: Thank you for review. Should we regenerate Lib/stringprep.py now? -- ___ Python tracker ___ ___ Py

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Martin v. Löwis added the comment: Ok, these patches all look fine. Thanks for your effort. -- ___ Python tracker ___ ___ Python-bugs-

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Serhiy Storchaka added the comment: And here is a patch which changes behavior. It adds check for validating end of table detection. -- Added file: http://bugs.python.org/file30404/mkstringprep_check.patch ___ Python tracker

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Serhiy Storchaka added the comment: Here is a minimal patch. -- Added file: http://bugs.python.org/file30402/mkstringprep_min.patch ___ Python tracker ___ ___

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Serhiy Storchaka added the comment: Here is a pure cosmetic patch. -- Added file: http://bugs.python.org/file30403/mkstringprep_cosmetic.patch ___ Python tracker ___

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Martin v. Löwis added the comment: I find the patch too large to review, and it appears to contain unrelated changes. Can you kindly split it up into two patches, namely A) changes that are really absolutely necessary to make it work again B) patches that are purely cosmetic, and do not affect

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Serhiy Storchaka added the comment: Is there a chance, Martin? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Georg Brandl added the comment: No need to hurry; no one apparently needs it anyway, and if there is a change let Martin review it before commit. -- ___ Python tracker ___ _

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Serhiy Storchaka added the comment: Georg, now Tools/unicode/mkstringprep.py is broken in all Python 3 branches (it not usable at all, under 3.2 it even raises SyntaxError). Do you object against fixing it in 3.2 and 3.3? -- nosy: +georg.brandl ___

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Serhiy Storchaka added the comment: Martin, are you have time to review now? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Changes by Georg Brandl : -- versions: +Python 3.4 -Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Martin v. Löwis added the comment: I don't consider it relevant for 3.3; I may have time to review only post-3.3. -- ___ Python tracker ___ __

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Serhiy Storchaka added the comment: To protect themselves from the surprises we need working mkstringprep.py. Martin, what do you say about a patch? -- ___ Python tracker ___ __

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Martin v. Löwis added the comment: The difference is in the reverse direction, right? I.e. the special case for U+0130 is removed. This is harmless: it just means that we don't need to special-case that anymore. I'm puzzled though that b3_exceptions doesn't become empty in 3.3. Supposedly, B.

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Changes by Serhiy Storchaka : -- keywords: +patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Changes by Serhiy Storchaka : -- keywords: +needs review -patch priority: normal -> low stage: -> patch review type: -> behavior ___ Python tracker ___

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Serhiy Storchaka added the comment: > If it produces different output today, we should investigate why. Lib/stringprep.py differs from updated Tools/unicode/mkstringprep.py output only by additional entity 0x130:'i\u0307' in b3_exceptions. In 3.2 and lower '\u0130'.lower() == '\u0069', in 3.

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Martin v. Löwis added the comment: Indeed, the code hasn't been run, and really shouldn't have to. If it produces different output today, we should investigate why. -- nosy: +loewis ___ Python tracker ___

[issue15239] Abandoned Tools/unicode/mkstringprep.py

Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file26228/mkstringprep.patch ___ Python tracker ___ _

[issue15239] Abandoned Tools/unicode/mkstringprep.py

New submission from Serhiy Storchaka : It seems that Tools/unicode/mkstringprep.py has not been used for many years. Now it is not valid Python3 code nor Python2 code. The proposed patch fixes all porting errors. Apparently, Lib/stringprep.py would have regenerated. Tools/unicode/mkstringprep