[issue1512791] module wave does no rounding

Mark Dickinson added the comment: Thanks for the feedback. I'm going to make an executive decision not to backport. Closing. -- status: open -> closed ___ Python tracker __

[issue1512791] module wave does no rounding

Neil Tallim added the comment: I use the wave module a fair bit and never once encountered this issue, so, yeah, it's probably a pretty low priority for backporting. It's definitely an edge-case sort of thing, the likes of which anyone affected has already handled in their application-level c

[issue1512791] module wave does no rounding

Changes by Mark Dickinson : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue1512791] module wave does no rounding

Mark Dickinson added the comment: I also meant to add that I left the int() call in, for slightly obscure reasons: round doesn't currently return an int for all numeric types---it does for ints, floats and Decimal instances, but not for Fraction instances (arguably a defect of the fractions

[issue1512791] module wave does no rounding

Mark Dickinson added the comment: Thanks, Neil. Committed to py3k in r84341. I'm a little reluctant to backport this to the maintenance branches, though, since it is a behaviour change, and it doesn't seem to me to be a critical bug fix. Any thoughts? -- resolution: -> fixed stage

[issue1512791] module wave does no rounding

Neil Tallim added the comment: The differences are small enough that it probably doesn't matter which one of us makes the extra changes. It'll take one step less for you to implement them while applying the fixes, so it's probably easiest if I leave that in your court. Thanks for asking if I

[issue1512791] module wave does no rounding

Mark Dickinson added the comment: Thanks for the patches. The general idea looks fine to me. Comments: - I'd like to see a doc entry indicating that float inputs to setframerate get rounded to the nearest integer. - In 3.x, the extra int() isn't necessary: round() returns an integer anyway

[issue1512791] module wave does no rounding

Mark Dickinson added the comment: I'll take a look at this. -- assignee: -> mark.dickinson nosy: +mark.dickinson ___ Python tracker ___ __

[issue1512791] module wave does no rounding

Changes by Mark Lawrence : -- stage: unit test needed -> patch review versions: +Python 3.1 ___ Python tracker ___ ___ Python-bugs-l

[issue1512791] module wave does no rounding

Neil Tallim added the comment: Attached a patch with a unit test and solution for this problem. Patch built against Python 3.2, r74246. Note: with Python 3.2, an error was thrown if the input value wasn't an integer because a deprecated struct-related cast was removed. It's debatable whether w

[issue1512791] module wave does no rounding

Neil Tallim added the comment: Attached a patch with a unit test and solution for this problem. Patch built against Python 2.7, r74246. Note: It may make more sense to just have wave.setframerate() assert that it is being fed an integer, and that's a simple fix that won't require a test. Howev

[issue1512791] module wave does no rounding

Changes by Daniel Diniz : -- priority: normal -> low stage: -> test needed type: -> feature request versions: +Python 2.7 ___ Python tracker ___ _