[issue15092] Using enum PyUnicode_Kind

2013-04-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> rejected stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue15092] Using enum PyUnicode_Kind

2013-04-07 Thread STINNER Victor
STINNER Victor added the comment: Python 3.3 has been released. I'm not sure that we can change the type of PyUnicode_Kind because of the stable API. By the way, I already tried to write a similar patch (use enum). I expected better performances, but it did not change anything. Can we close t

[issue15092] Using enum PyUnicode_Kind

2012-07-18 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: I'd strongly prefer not having "enum" everywhere. "PyUnicode_Kind" alone is certainly possible, maybe with a typedef? -- nosy: +amaury.forgeotdarc ___ Python tracker _

[issue15092] Using enum PyUnicode_Kind

2012-07-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Please, can anyone do the review of this large but trivial patch? -- ___ Python tracker ___ ___ P

[issue15092] Using enum PyUnicode_Kind

2012-06-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Since assert(0) always fails, return can never happen (and was not added > above. So I would think remove it. This will cause a compiler warning in non-debug mode. Here is updated patch with all other comments taken into account. -- Added file: h

[issue15092] Using enum PyUnicode_Kind

2012-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Since we have defined an enum, I think we should use it consistently. (Am I correct in thinking it was added after the initial patches.) So I did a sanity check of -/+ lines for perhaps unintended changes. The only things I found to comment on, mostly somewha

[issue15092] Using enum PyUnicode_Kind

2012-06-17 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +haypo stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15092] Using enum PyUnicode_Kind

2012-06-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Now a string kind declared in different places of code as `enum PyUnicode_Kind`, `int` or `unsigned int`. Working on the codecs optimization, I noticed that sometimes the use of `enum PyUnicode_Kind` gives a little advantage over the use of int's. Probabl