[issue15075] XincludeTest failure in test_xml_etree

2013-01-05 Thread Eli Bendersky
Eli Bendersky added the comment: I investigated a bit, and type checks were added to protect from such mixing. Please open a new patch with a speficic reproducer if you run into similar problems (interepreter crash). -- ___ Python tracker

[issue15075] XincludeTest failure in test_xml_etree

2012-12-31 Thread Stefan Behnel
Stefan Behnel added the comment: If runtime checks are needed to prevent mixing arbitrary objects into the tree, then I don't think they should be considered too costly. I agree with Florent that this is worth reopening. It doesn't look like a "Tests" bug to me rather a "Lib"/"XML" bug. -

[issue15075] XincludeTest failure in test_xml_etree

2012-06-16 Thread Eli Bendersky
Eli Bendersky added the comment: No need, the cause for the segfault is known. What happens is that Element objects from the Python module get intermixed with Element objects from the C module, and these are incompatible. The C module traversal functions assume they can cast Elements to a kno

[issue15075] XincludeTest failure in test_xml_etree

2012-06-16 Thread Florent Xicluna
Florent Xicluna added the comment: > File "/home/eliben/python-src/33/Lib/test/regrtest.py", line 710 in main > File "/home/eliben/python-src/33/Lib/test/regrtest.py", line 1829 in > > File "/home/eliben/python-src/33/Lib/runpy.py", line 75 in _run_code > File "/home/eliben/python-src/

[issue15075] XincludeTest failure in test_xml_etree

2012-06-15 Thread Eli Bendersky
Eli Bendersky added the comment: Opened #15083 to track the *actual* solution to this problem, which should restructure the tests to be safer. -- superseder: -> Rewrite ElementTree tests in a cleaner and safer way ___ Python tracker

[issue15075] XincludeTest failure in test_xml_etree

2012-06-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5782efaa8d68 by Eli Bendersky in branch 'default': Make the test more resilient to test-run order (closes #15075) http://hg.python.org/cpython/rev/5782efaa8d68 -- nosy: +python-dev resolution: -> fixed stage: test needed -> committed/rejec

[issue15075] XincludeTest failure in test_xml_etree

2012-06-15 Thread Eli Bendersky
Eli Bendersky added the comment: Here is a patch that solves the current problem. A longer term solution would be to have a cleaner test plan for ET in general, without monkey-patching at all, and without state that causes test-order dependencies. -- keywords: +patch Added file: http

[issue15075] XincludeTest failure in test_xml_etree

2012-06-15 Thread Eli Bendersky
Eli Bendersky added the comment: As suspected, the cause is that xinclude_loader manages to somehow import the C version of ET, although test_xml_etree tries to enforce the Python version. This is probably because test___all__ imports all modules and leaves stuff in the import cache. What ca

[issue15075] XincludeTest failure in test_xml_etree

2012-06-15 Thread Eli Bendersky
Eli Bendersky added the comment: After some tinkering I found which test when run before test_xml_etree causes it to crash: $ ./python -m test.regrtest test___all__ test_xml_etree [1/2] test___all__ [2/2] test_xml_etree Fatal Python error: Segmentation fault Current thread 0x7f771ecec700:

[issue15075] XincludeTest failure in test_xml_etree

2012-06-15 Thread Nick Coghlan
Changes by Nick Coghlan : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue15075] XincludeTest failure in test_xml_etree

2012-06-15 Thread Eli Bendersky
New submission from Eli Bendersky : The XincludeTest test-case in test_xml_etree is now skipped, because it fails in an intermittent manner. I can reproduce the failure when running full regrtest with -j1, but not -j8, and not when run individually. The failure is most likely due to the test i