[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

Hynek Schlawack added the comment: Thank you for your contribution Chris! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

Roundup Robot added the comment: New changeset dc080e19f7aa by Hynek Schlawack in branch '2.7': #14880: Fix kwargs notation in csv.reader, .writer & .register_dialect http://hg.python.org/cpython/rev/dc080e19f7aa -- nosy: +python-dev ___ Python tracke

[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

Hynek Schlawack added the comment: It seems correct like that: static PyObject * csv_register_dialect(PyObject *module, PyObject *args, PyObject *kwargs) { PyObject *name_obj, *dialect_obj = NULL; PyObject *dialect; if (!PyArg_UnpackTuple(args, "", 1, 2, &name_obj, &dialect_obj))

[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

Petri Lehtinen added the comment: Well, I wasn't sure about [optional] params before **kwargs. But if that's ok, then I think the patch is good. -- ___ Python tracker ___ __

[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

Hynek Schlawack added the comment: What does bother you? Both sigs look like in py3 if I'm looking correctly. -- ___ Python tracker ___ __

[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

Petri Lehtinen added the comment: Chris: Thanks for the patch. I'm not sure register_dialect()'s signature is good like that, though. Hynek, what do you think? -- stage: -> patch review ___ Python tracker ___

[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

Changes by Chris Rebert : -- keywords: +patch Added file: http://bugs.python.org/file27008/issue14880.patch ___ Python tracker ___ ___

[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

Petri Lehtinen added the comment: I verified from the source that it should be **fmtparams also in 2.7. Make sure you change the description texts, too, to s/fmtparam/fmtparams/. -- nosy: +petri.lehtinen ___ Python tracker

[issue14880] csv.reader and .writer use wrong kwargs notation in 2.7 docs

New submission from Hynek Schlawack : It says > csv.reader(csvfile[, dialect='excel'][, fmtparam]) > csv.writer(csvfile[, dialect='excel'][, fmtparam]) in 2.7. I presume it should be like in 3.x: > csv.reader(csvfile, dialect='excel', **fmtparams) > csv.writer(csvfile, dialect='excel', **fmtpa