[issue14853] test_file.py depends on sys.stdin being unseekable

Łukasz Langa added the comment: Thanks, Irit! ✨ 🍰 ✨ -- assignee: ezio.melotti -> iritkatriel resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue14853] test_file.py depends on sys.stdin being unseekable

miss-islington added the comment: New changeset 4e0147ec50aa62315c5a9aa7c88c181f57aadf42 by Miss Islington (bot) in branch '3.10': bpo-14853: add back the stdin test, skip if stdin is redirected (GH-27694) https://github.com/python/cpython/commit/4e0147ec50aa62315c5a9aa7c88c181f57aadf42 ---

[issue14853] test_file.py depends on sys.stdin being unseekable

Łukasz Langa added the comment: New changeset 897c87045c7435254fd330c6ea48204f056e4afc by Miss Islington (bot) in branch '3.9': bpo-14853: add back the stdin test, skip if stdin is redirected (GH-27694) (GH-27698) https://github.com/python/cpython/commit/897c87045c7435254fd330c6ea48204f056e4a

[issue14853] test_file.py depends on sys.stdin being unseekable

Irit Katriel added the comment: New changeset 8ed183391241f0c73e7ba7f42b1d49fc02985f7b by Irit Katriel in branch 'main': bpo-14853: add back the stdin test, skip if stdin is redirected (GH-27694) https://github.com/python/cpython/commit/8ed183391241f0c73e7ba7f42b1d49fc02985f7b -- _

[issue14853] test_file.py depends on sys.stdin being unseekable

Change by miss-islington : -- pull_requests: +26184 pull_request: https://github.com/python/cpython/pull/27698 ___ Python tracker ___ __

[issue14853] test_file.py depends on sys.stdin being unseekable

Change by miss-islington : -- nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +26183 pull_request: https://github.com/python/cpython/pull/27697 ___ Python tracker _

[issue14853] test_file.py depends on sys.stdin being unseekable

Change by Irit Katriel : -- versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.3, Python 3.4 ___ Python tracker ___

[issue14853] test_file.py depends on sys.stdin being unseekable

Change by Irit Katriel : -- nosy: +iritkatriel nosy_count: 7.0 -> 8.0 pull_requests: +26180 pull_request: https://github.com/python/cpython/pull/27694 ___ Python tracker ___ __

[issue14853] test_file.py depends on sys.stdin being unseekable

Martin Panter added the comment: Long story short: Don’t change Python 2, and just restore the seek(-1) test in 3. I agree in general it is better to skip a test than completely remove it. However, in Python 2, the test that Victor proposes to restore is redundant with test_file2k. Sys.stdin

[issue14853] test_file.py depends on sys.stdin being unseekable

Changes by STINNER Victor : Added file: http://bugs.python.org/file37614/test_file.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue14853] test_file.py depends on sys.stdin being unseekable

STINNER Victor added the comment: The same issue was reported for test_file2k: issue #23168. I modified test_file2k to skip sys.stdin.seek() test if stdin is not a TTY. I prefer to skip a test in a specific case, instead of removing it completly. I propose to add again the test in test_file, w

[issue14853] test_file.py depends on sys.stdin being unseekable

Ezio Melotti added the comment: Fixed, thanks for the patch! -- assignee: -> ezio.melotti resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: +Python 3.3, Python 3.4 ___ Python tracker

[issue14853] test_file.py depends on sys.stdin being unseekable

Roundup Robot added the comment: New changeset 17542d36effd by Ezio Melotti in branch '2.7': #14853: remove test that was making too many assumptions about stdin. Patch by Elena Oat. http://hg.python.org/cpython/rev/17542d36effd New changeset c5d847ee354a by Ezio Melotti in branch '3.3': #1485

[issue14853] test_file.py depends on sys.stdin being unseekable

Antoine Pitrou added the comment: Elena, your patch looks ok to me, thank you. Could you sign a contributor's agreement? http://www.python.org/psf/contrib/ (or have you already done so?) -- ___ Python tracker _

[issue14853] test_file.py depends on sys.stdin being unseekable

Ezio Melotti added the comment: FTR Python 3 raises "io.UnsupportedOperation: underlying stream is not seekable" on unseekable files and "ValueError: negative seek position -1" on seekable ones, whereas Python 2 raises "IOError: [Errno 29] Illegal seek" on unseekable files and doesn't raise an

[issue14853] test_file.py depends on sys.stdin being unseekable

Elena Oat added the comment: testStdin test is useless, it expects that stdin is always unseekable, but since sys.stdin could be any file, i.e. it can be seekable. The patch removes the test. -- keywords: +patch nosy: +Elena.Oat, pitrou Added file: http://bugs.python.org/file30828/14

[issue14853] test_file.py depends on sys.stdin being unseekable

New submission from Gregory P. Smith : ./python Lib/test/test_file.py# passes ./python Lib/test/test_file.py , ) not raised == FAIL: testStdin (__main__.PyOtherFileTests)