[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4445608cf434 by Larry Hastings in branch 'default': Issue #14815: Bugfix: the PyLong fed into the seed generator must be unsigned. http://hg.python.org/cpython/rev/4445608cf434 -- ___ Python tracker

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-24 Thread Larry Hastings
Changes by Larry Hastings : -- resolution: -> fixed stage: -> commit review status: open -> closed type: -> enhancement ___ Python tracker ___

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 166599219bd4 by Larry Hastings in branch 'default': Issue #14815: Use Py_ssize_t instead of long for the object hash, to http://hg.python.org/cpython/rev/166599219bd4 -- nosy: +python-dev ___ Python trac

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: I got bored so I made you a patch. -- keywords: +patch Added file: http://bugs.python.org/file26125/larry.random_seed.ssize_t.1.diff ___ Python tracker ___

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-16 Thread Larry Hastings
Changes by Larry Hastings : -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-16 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: rhettinger -> loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-05-17 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-05-16 Thread Raymond Hettinger
Raymond Hettinger added the comment: This is a reasonable change. The benefits of using all 64-bits outweigh the small downside of losing the reproducibility of previously generated sequences that relied on the object hash. -- ___ Python tracker

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-05-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-05-15 Thread Martin v . Löwis
New submission from Martin v. Löwis : random_seed has this code: long hash = PyObject_Hash(arg); On Win64, Py_hash_t is a 64-bit type, yet long is a 32-bit type, so this truncates. I think the computation should be done in Py_ssize_t. -- messages: 160720 nosy: loewis priority: norma