[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Roundup Robot added the comment: New changeset 8b8ac7adbf49 by Martin Panter in branch '2.7': Issue #14771: Redirect GDB's stdin to avoid messing the terminal settings https://hg.python.org/cpython/rev/8b8ac7adbf49 New changeset c87cc05af8e7 by Martin Panter in branch '3.5': Issue #14771: Redire

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Martin Panter added the comment: I found that if you redirect GDB’s stdin if fixes all the problems. I don’t fully understand what GDB is doing to change the terminal’s foreground process group. In my patch I set stdin to a pipe. It is like using DEVNULL, but should be compatible with Python

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Mark Lawrence added the comment: @Antoine/Serhiy I believe that you'd want to follow up on this. -- nosy: +BreamoreBoy ___ Python tracker ___

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Antoine Pitrou added the comment: Ah, and the test_ioctl() method needs to be fixed too. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Antoine Pitrou added the comment: Given what _check_ioctl_mutate_len() seems to be designed to check, perhaps we should relax: self.assertIn(rpgrp, ids) into: self.assertNotEqual(rpgrp, fill) or perhaps simply: self.assertGreater(rpgrp, 0) -- __

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Antoine Pitrou added the comment: Ah, I see, that's because of the "Skip if another process is in foreground" thing? -- ___ Python tracker ___ __

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Antoine Pitrou added the comment: > Perhaps we need a possibility to mark a test that it can't run in parallel. > I suspect some multiprocess tests fail for same reason. Well, first I would like to know what the underlying problem is. -j doesn't use multiprocessing, it spawns standalone process

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Serhiy Storchaka added the comment: Perhaps we need a possibility to mark a test that it can't run in parallel. I suspect some multiprocess tests fail for same reason. -- ___ Python tracker ___

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

Changes by Antoine Pitrou : -- stage: -> needs patch title: Occasional failure in test_ioctl -> Occasional failure in test_ioctl when run parallel with test_gdb versions: +Python 3.4 ___ Python tracker __

[issue14771] Occasional failure in test_ioctl

Antoine Pitrou added the comment: Nice catch, Serhiy. I wouldn't have suspected test_gdb. -- ___ Python tracker ___ ___ Python-bugs-li

[issue14771] Occasional failure in test_ioctl

Serhiy Storchaka added the comment: Bingo! $ ./python -m test.regrtest -j 4 test_gdb test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl

[issue14771] Occasional failure in test_ioctl

Serhiy Storchaka added the comment: $ ./python -m test.regrtest -j 4 test_gdb test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl [ 1/20]

[issue14771] Occasional failure in test_ioctl

Serhiy Storchaka added the comment: $ ./python -m test.regrtest -j 2 test_gdb test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl test_ioctl [ 1/10] test_ioctl [ 2/10] test_ioctl [ 3/10] test_ioctl [ 4/10] test_ioctl [ 5/10] test_ioctl [ 6/10] test_ioctl [ 7/1

[issue14771] Occasional failure in test_ioctl

Serhiy Storchaka added the comment: What is ? Can you please expose several lines of regrtest output before and after this error? When "/1" appeared? I suspect test_gdb: $ ./python -m test.regrtest -j 2 test_gdb test_gdb [1]+ Stopped ./python -m test.regrtest -j 2 test_gdb te

[issue14771] Occasional failure in test_ioctl

Antoine Pitrou added the comment: > Serhiy Storchaka added the comment: > > Do you use -r option? No. Usually just -j -- ___ Python tracker ___

[issue14771] Occasional failure in test_ioctl

Serhiy Storchaka added the comment: Do you use -r option? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue14771] Occasional failure in test_ioctl

Antoine Pitrou added the comment: > Beside this, the code at the top of the module checks the same > condition and skip the tests if it is wrong. Race condition happened > -- the process has been put into the background between executing > these two codes. What command line you run the test? It

[issue14771] Occasional failure in test_ioctl

Serhiy Storchaka added the comment: Third argument of ioctl should be not "", but a bytes object with platform dependent length sizeof(pid_t). Beside this, the code at the top of the module checks the same condition and skip the tests if it is wrong. Race condition happened -- the process

[issue14771] Occasional failure in test_ioctl

Changes by Ezio Melotti : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue14771] Occasional failure in test_ioctl

Ezio Melotti added the comment: Can you still reproduce this issue? Do you use any specific flag to run the tests? What OS is this? I tried on linux, solaris, and aix with ``./python -m test -F test_ioctl`` for about 1k loops, and couldn't reproduce the issue. -- nosy: +ezio.melotti _

[issue14771] Occasional failure in test_ioctl

New submission from Antoine Pitrou : This happens from time to time on my desktop computer: [151/354/1] test_ioctl test test_ioctl failed -- Traceback (most recent call last): File "/home/antoine/cpython/32/Lib/test/test_ioctl.py", line 36, in test_ioctl self.assertIn(rpgrp, ids) Assertion