[issue1475523] gettext breaks on plural-forms header

A.M. Kuchling added the comment: #17898 has been closed with basically the same fix as Mark's patch, so I'll close this issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue1475523] gettext breaks on plural-forms header

A.M. Kuchling added the comment: I think that #17898 is in fact a duplicate of this bug, due to old values of k and v confusing things. Mark's patch looks correct to me, but the patch in #17898 also adds a test. If that patch gets reviewed, I'll apply it to 3.4/3.5, and possibly to 2.7. ---

[issue1475523] gettext breaks on plural-forms header

Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue1475523] gettext breaks on plural-forms header

Changes by Terry J. Reedy : -- versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue1475523] gettext breaks on plural-forms header

Changes by Éric Araujo : -- dependencies: -Add tests for some scripts in Tools/scripts ___ Python tracker ___ ___ Python-bugs-list

[issue1475523] gettext breaks on plural-forms header

Changes by Éric Araujo : -- dependencies: +Add tests for some scripts in Tools/scripts ___ Python tracker ___ ___ Python-bugs-list m

[issue1475523] gettext breaks on plural-forms header

Dirkjan Ochtman added the comment: Okay, I've filed issue12425. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue1475523] gettext breaks on plural-forms header

Martin v. Löwis added the comment: Ok. This is a different issue, then. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue1475523] gettext breaks on plural-forms header

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue1475523] gettext breaks on plural-forms header

Dirkjan Ochtman added the comment: Looks like this was the problem: http://git.fedorahosted.org/git/?p=virt-manager.git;a=commitdiff;h=cb56316cf3702f03b05e30f406ff3028e45f7bfb. E.g., the empty Plural-Forms header is throwing off the python gettext parser. -- _

[issue1475523] gettext breaks on plural-forms header

Martin v. Löwis added the comment: It's difficult to tell whether it's the same thing. Is the po file in question available readily for inspection? -- ___ Python tracker ___

[issue1475523] gettext breaks on plural-forms header

Dirkjan Ochtman added the comment: This looks similar to https://bugs.gentoo.org/show_bug.cgi?id=373115. Is it the same thing, or should I file a separate bug for it? (Sorry, I don't intend to hijack this bug, but I don't know much about gettext and the patch here looks somewhat similar to th

[issue1475523] gettext breaks on plural-forms header

Changes by Terry J. Reedy : -- versions: +Python 3.3 -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue1475523] gettext breaks on plural-forms header

Changes by Ricky Zhou : -- nosy: +ricky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue1475523] gettext breaks on plural-forms header

Changes by Éric Araujo : -- nosy: -BreamoreBoy resolution: accepted -> ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue1475523] gettext breaks on plural-forms header

Éric Araujo added the comment: Could you follow the guidelines at http://www.python.org/dev/patches/ to create patches? Thanks in advance. I wonder why you call tearDown from setUp. Doesn’t unittest do that for you when there is a failure in setUp? Also, you could use a with statement inst

[issue1475523] gettext breaks on plural-forms header

Mark Lawrence added the comment: Point taken I'll settle for PluralFormsTest unless there's a better idea. Assuming patch acceptance could a committer do this please? -- ___ Python tracker

[issue1475523] gettext breaks on plural-forms header

Senthil Kumaran added the comment: Minor change request. +class Bug1448060(GettextBaseTest): Can you name the test class something more meaningful like PluralFormsTest or something like that. It is helpful when looking at it later. (Btw, this can be done by the committer during checkin too)

[issue1475523] gettext breaks on plural-forms header

Mark Lawrence added the comment: Sorry, forgot to say that the patched code passed all tests in the patched unit test file. -- ___ Python tracker ___

[issue1475523] gettext breaks on plural-forms header

Mark Lawrence added the comment: Attached patch is my take on the fix to this, it's a two line change to gettext.py for 2.7. If the change is accepted I'll provide another patch for py3k. Nosy list updated while I'm at it. -- nosy: +BreamoreBoy, dsegan, potorange -merwok versions:

[issue1475523] gettext breaks on plural-forms header

Changes by Éric Araujo : -- nosy: +merwok ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue1475523] gettext breaks on plural-forms header

Changes by Éric Araujo : -- resolution: -> accepted title: patch fixing #1448060 (gettext.py bug) -> gettext breaks on plural-forms header versions: +Python 2.7, Python 3.2 ___ Python tracker __