[issue14746] Remove redundant paragraphs from getargs.c skipitem()

2012-05-08 Thread Larry Hastings
Larry Hastings added the comment: Thanks for the double-check. I should have more confidence! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker __

[issue14746] Remove redundant paragraphs from getargs.c skipitem()

2012-05-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8ab37fa24e58 by Larry Hastings in branch 'default': Issue #14746: Remove redundant paragraphs from skipitem() in Python/getargs.c. http://hg.python.org/cpython/rev/8ab37fa24e58 -- nosy: +python-dev ___ P

[issue14746] Remove redundant paragraphs from getargs.c skipitem()

2012-05-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: > > At least Py_ssize_t *could* have a different width from "PyObject *". > > Not "Py_ssize_t", "Py_ssize_t *". Ah, fair enough then. Looks ok to me. -- ___ Python tracker _

[issue14746] Remove redundant paragraphs from getargs.c skipitem()

2012-05-08 Thread Larry Hastings
Larry Hastings added the comment: > I'm not sure what you're proposing to fix. It seems to save at > most a couple of lines of (obvious) code? Well, I *did* specify low priority. Attached is the patch for what I had in mind. > At least Py_ssize_t *could* have a different width from "PyObject

[issue14746] Remove redundant paragraphs from getargs.c skipitem()

2012-05-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'm not sure what you're proposing to fix. It seems to save at most a couple of lines of (obvious) code? At least Py_ssize_t *could* have a different width from "PyObject *". -- nosy: +mark.dickinson, pitrou ___ Pyt

[issue14746] Remove redundant paragraphs from getargs.c skipitem()

2012-05-07 Thread Larry Hastings
New submission from Larry Hastings : There's code like this in skipitem() in Python/getargs.c: case 'b': /* byte -- very short int */ /* ... a zillion more case statements here ... */ case 'C': /* unicode char */ case 'p': /* boolean predicate */ { (void) va_a