[issue14679] Define an __all__ for html.parser

Changes by Ezio Melotti : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue14679] Define an __all__ for html.parser

Roundup Robot added the comment: New changeset 1f7ce8af3356 by Ezio Melotti in branch 'default': #14679: add an __all__ (that contains only HTMLParser) to html.parser. http://hg.python.org/cpython/rev/1f7ce8af3356 -- nosy: +python-dev ___ Python track

[issue14679] Define an __all__ for html.parser

Senthil Kumaran added the comment: I think, HTMLParseError should also be defined __all__ (all also servers as what public classes/methods to look for sometimes and sets some expectation while reading the code.) There is no deprecation warning added in the class here. -- nosy: +orsen

[issue14679] Define an __all__ for html.parser

Ezio Melotti added the comment: The module only defines 2 public objects: HTMLParser and HTMLParseError. The attached patch adds an __all__ with only HTMLParser. Should HTMLParseError be included too, even though it's deprecated and will be removed in 3.5? @Michele: __all__ won't fix that, b

[issue14679] Define an __all__ for html.parser

Michele Orrù added the comment: "# Internal" appears only in HTMLParser's methods; how could __all__ fix this? -- nosy: +maker ___ Python tracker ___

[issue14679] Define an __all__ for html.parser

Ezio Melotti added the comment: The issue with Django seems to be solved, but as Terry suggested in http://mail.python.org/pipermail/python-dev/2012-April/119087.html, adding an __all__ would be a good idea. I'm changing the scope of the issue accordingly. -- assignee: -> ezio.melott